Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Started Guide guide fixes #890

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Conversation

fadushin
Copy link
Collaborator

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

@fadushin fadushin force-pushed the gs-guide-fixes branch 2 times, most recently from 095c5f2 to 584475c Compare October 25, 2023 23:36
@fadushin fadushin marked this pull request as ready for review October 25, 2023 23:36
Copy link
Collaborator

@UncleGrumpy UncleGrumpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of typos and an addition I should have made myself, but didn't notice we were missing until now.

doc/src/getting-started-guide.md Show resolved Hide resolved
doc/src/getting-started-guide.md Outdated Show resolved Hide resolved
doc/src/getting-started-guide.md Outdated Show resolved Hide resolved
doc/src/getting-started-guide.md Outdated Show resolved Hide resolved
doc/src/getting-started-guide.md Outdated Show resolved Hide resolved
doc/src/getting-started-guide.md Outdated Show resolved Hide resolved
doc/src/getting-started-guide.md Outdated Show resolved Hide resolved
doc/src/getting-started-guide.md Outdated Show resolved Hide resolved
doc/src/getting-started-guide.md Outdated Show resolved Hide resolved
@fadushin
Copy link
Collaborator Author

@UncleGrumpy are you okay with me fixing the STM32 packbeam instructions we identified off-line in this PR? Seems like we need to fix it, and might as well do here.

@UncleGrumpy
Copy link
Collaborator

@UncleGrumpy are you okay with me fixing the STM32 packbeam instructions we identified off-line in this PR? Seems like we need to fix it, and might as well do here.

Absolutely!

@UncleGrumpy
Copy link
Collaborator

Sorry I spotted one more discrepancy in the requirements for stm32.

Signed-off-by: Fred Dushin <fred@dushin.net>
@fadushin fadushin merged commit 92eed62 into atomvm:master Oct 28, 2023
3 checks passed
@fadushin fadushin deleted the gs-guide-fixes branch October 28, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants