fix readme instructions #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pepe Márquez Romero <pepe.marquezromero@protonmail.com>
UncleGrumpy
suggested changes
Jan 5, 2026
Contributor
UncleGrumpy
left a comment
UncleGrumpy
left a comment
There was a problem hiding this comment.
This looks great. Thank you again! We really appreciate the contributions.
You probably want to consider that the PR comment used to open the PR will also be included in the merge, so these should be a brief description of the changes so we keep a clean and easy to follow commit logs.
Contributor
|
You can always ask for a review in a follow up comment, or better yet use the “request review” feature and select a suggested reviewer (or enter @whoever if they aren’t listed). |
Contributor
|
Thanks for updating the commit message, it will be more helpful a year from now when someone is reading the commit log. |
UncleGrumpy
approved these changes
Jan 5, 2026
bettio
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the instructions for building the the web locally.