proper way to include a nif in AtomVM build

[mihailacusteanu]

So I am trying to use this extension, but I am not quite sure how to include the nif(s).

I downloaded the AtomVM repo and then I've put my atomvm_adc folder to src/platforms/esp32 but when I run
idf.py set-target esp32
I get this error:

CMake Error at /Users/mihai/esp/esp-idf/tools/cmake/build.cmake:268 (message):
  Failed to resolve component 'esp_adc_cal'.
Call Stack (most recent call first):
  /Users/mihai/esp/esp-idf/tools/cmake/build.cmake:310 (__build_resolve_and_add_req)
  /Users/mihai/esp/esp-idf/tools/cmake/build.cmake:599 (__build_expand_requirements)
  /Users/mihai/esp/esp-idf/tools/cmake/project.cmake:548 (idf_build_process)
  CMakeLists.txt:32 (project)


-- Configuring incomplete, errors occurred!
HINT: The component esp_adc_cal could not be found. This could be because: component name was misspelled, the component was not added to the build, the component has been moved to the IDF component manager or has been removed and refactored into some other component.
Please look out for component in 'https://components.espressif.com' and add using 'idf.py add-dependency' command.
Refer to the migration guide for more details about moved components.
Refer to the build-system guide for more details about how components are found and included in the build.

I tried to put the component manually in same src/platforms/esp32 folder but then I get another component missing...and so one until I get a dependency that is deprecated.
I guess that it should be another way to automatically solve those dependencies?
or can you suggest any other solution?

[UncleGrumpy]

You need to clone the repository into src/platforms/esp32/components. I am not sure which ESP-IDF version you were using, but this driver hasn't been updated to work with 5.x versions, there were lots of breaking changes. An update should be available soon.
I also recommend running idf.py clean and idf.py menuconfig this will make sure the atomvm_adc component is configured to be included in the build.

[mihailacusteanu]

indeed the problem was related to the idf version. the atomvm_adc is compiling and working now!
I am now experience a problem with atomvm_dh11 which I also encountered with atomvm_adc while debugging:

[1052/1081] Building C object esp-idf/atomvm_dht/CMakeFiles/__idf_atomvm_dht.dir/nifs/atomvm_dht.c.obj
FAILED: esp-idf/atomvm_dht/CMakeFiles/__idf_atomvm_dht.dir/nifs/atomvm_dht.c.obj

...

[1063/1081] Building C object esp-idf/libatomvm/libAtomVM/CMakeFiles/libAtomVM.dir/context.c.obj
In file included from /Users/mihai/Documents/atomvm/new_atm/AtomVM/src/libAtomVM/sys.h:41,
                 from /Users/mihai/Documents/atomvm/new_atm/AtomVM/src/libAtomVM/context.c:34:
/Users/mihai/esp/esp-idf/components/newlib/platform_include/time.h:22:2: warning: #include_next is a GCC extension
 #include_next <time.h>
  ^~~~~~~~~~~~
ninja: build stopped: subcommand failed.
ninja failed with exit code 1

I did use idf.py clean and start over multiple times

do you have any idea if this comes from a common mistake?

[fadushin]

It's possible that driver has rotted on the vine -- it's a bit-banging driver and the DHT sensors are not exactly known for their accuracy. I will try to take a look after work tonight.