Skip to content

Robust essential cut (lazy constraint) generation #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 27, 2021
Merged

Conversation

guimarqu
Copy link
Contributor

@guimarqu guimarqu commented Feb 25, 2021

Essential cut gen is performed :

  • in the cut callback algorithm
  • each time the colgen algorithm finds an integer solution
  • after heuristic

for colgen : when the cut violates the solution, the colgen restarts at phase 3 if it was at phase 3 and at phase 1 if it was at phase 1 or 2

fix #450

@guimarqu guimarqu added the enhancement New feature or request label Feb 25, 2021
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #452 (b2c19c0) into master (7265c97) will increase coverage by 0.09%.
The diff coverage is 94.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #452      +/-   ##
==========================================
+ Coverage   80.71%   80.81%   +0.09%     
==========================================
  Files          51       51              
  Lines        4310     4347      +37     
==========================================
+ Hits         3479     3513      +34     
- Misses        831      834       +3     
Impacted Files Coverage Δ
src/MOIcallbacks.jl 94.23% <83.33%> (+0.61%) ⬆️
src/Algorithm/colgen.jl 96.74% <93.10%> (+0.10%) ⬆️
src/Algorithm/basic/cutcallback.jl 97.14% <95.23%> (+0.84%) ⬆️
src/Algorithm/conquer.jl 82.07% <100.00%> (+2.28%) ⬆️
src/Algorithm/branching/branchinggroup.jl 86.51% <0.00%> (-1.13%) ⬇️
src/Algorithm/branching/branchingalgo.jl 90.75% <0.00%> (-0.85%) ⬇️
src/Algorithm/storage.jl 73.77% <0.00%> (-0.82%) ⬇️
src/decomposition.jl 98.50% <0.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7265c97...dc62507. Read the comment docs.

@guimarqu guimarqu marked this pull request as ready for review February 25, 2021 23:18
@guimarqu guimarqu requested a review from rrsadykov February 25, 2021 23:18
@guimarqu guimarqu changed the title Essential cut (lazy constraint) generation Robust essential cut (lazy constraint) generation Feb 25, 2021
@guimarqu guimarqu enabled auto-merge (squash) February 25, 2021 23:18
@guimarqu guimarqu disabled auto-merge February 25, 2021 23:19
@guimarqu guimarqu requested a review from artalvpes February 25, 2021 23:19
@guimarqu
Copy link
Contributor Author

guimarqu commented Feb 25, 2021

I think it's wrong, it should restart at phase 2 in colgen because it never does essential cutgen at phase 1. I'll fix tomorrow.

@guimarqu guimarqu requested a review from rrsadykov February 26, 2021 11:07
@guimarqu guimarqu mentioned this pull request Feb 26, 2021
@guimarqu guimarqu enabled auto-merge (squash) February 27, 2021 09:30
@guimarqu guimarqu merged commit 02c14a4 into master Feb 27, 2021
@guimarqu guimarqu deleted the lazycuts branch March 1, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to use Coluna along with Lazy constraints ?
2 participants