Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve traceback of import errors #188

Merged
merged 4 commits into from
Feb 3, 2019
Merged

Conversation

valq7711
Copy link
Collaborator

@valq7711 valq7711 commented Feb 2, 2019

No description provided.

@atsepkov
Copy link
Owner

atsepkov commented Feb 2, 2019

Not related to the PR, but what's the state of ES6 imports (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import) and what are their limitations, if any, compared to RS? The import mechanism here predates the ES6 version, and has been great, but does it make sense to eventually drop ES5 support and replace this with the modern version?

@valq7711
Copy link
Collaborator Author

valq7711 commented Feb 2, 2019

It's impossible to create and run module in browser (you can compile but to run you have to send it to the server and get it back).
It will force rs-users to dive into webpack if it's necessary to bundle modules into one (or few) file(s).
If we drop the existing import implementation, Node.js and webpack will become hard dependencies - I think, it's bad news for pythonic-people.
On the other hand, module-in-browser could be produced by setting private_scope to false and adding JS('export {...}')/JS('import {...} from ...') even now! - as for me, this is quite enough.

@atsepkov atsepkov merged commit 65711b6 into master Feb 3, 2019
@valq7711 valq7711 deleted the valq7711-import_traceback branch March 6, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants