Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added unit tests for self key encryption and shared key encryption #1197

Merged
merged 6 commits into from
Jan 15, 2024
Merged

fix: added unit tests for self key encryption and shared key encryption #1197

merged 6 commits into from
Jan 15, 2024

Conversation

murali-shris
Copy link
Member

- What I did

  • added unit tests for shared key encryption and self key encryption
  • when encryption util is replaced with at_chops methods, these tests can be used to verify whether new code produces same output as old code.
    - How I did it
  • added tests for postitive and negative scenarios in shared_encryption_test.dart, self_key_encryption_test.dart
    - How to verify it
  • run the unit tests

gkc
gkc requested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please always generate keypairs rather than hard-coding
  • Even though I'm pretty familiar with the code, it is very time-consuming to understand what is being set up by each test and what is being verified.

@murali-shris
Copy link
Member Author

  • Please always generate keypairs rather than hard-coding
  • Even though I'm pretty familiar with the code, it is very time-consuming to understand what is being set up by each test and what is being verified.

I have made the changes. Please re-review

@murali-shris murali-shris requested a review from gkc January 10, 2024 06:17
@gkc gkc merged commit 8393445 into trunk Jan 15, 2024
8 checks passed
@gkc gkc deleted the encryption_tests branch January 15, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkc gkc gkc approved these changes

@sitaram-kalluri sitaram-kalluri Awaiting requested review from sitaram-kalluri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murali-shris @gkc