Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Max key length check #1290

Merged
merged 5 commits into from
Apr 11, 2024
Merged

fix: Max key length check #1290

merged 5 commits into from
Apr 11, 2024

Conversation

murali-shris
Copy link
Member

@murali-shris murali-shris commented Apr 11, 2024 •
edited
Loading

- What I did

  • added tests of max length check
  • uptake at_commons 4.0.6 and at_persistence_secondary_server 3.0.62 which have the fix for key length check
    - How I did it
  • modified pubspec to upgrade dependencies
  • added unit tests in at_client_impl_test and local_secondary_test
    - How to verify it
    tests should pass

@murali-shris murali-shris requested review from gkc and sitaram-kalluri and removed request for gkc April 11, 2024 09:49
@murali-shris murali-shris marked this pull request as ready for review April 11, 2024 11:57
@murali-shris murali-shris merged commit da80132 into trunk Apr 11, 2024
10 checks passed
@murali-shris murali-shris deleted the hive_max_length_check branch April 11, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sitaram-kalluri sitaram-kalluri sitaram-kalluri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murali-shris @sitaram-kalluri