New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add feature flag to allow atClient for offline access #1359

Closed

sitaram-kalluri wants to merge 1 commit into trunk from add_offline_access_feature_flag

Member

sitaram-kalluri commented Jul 22, 2024

- What I did

Reference to the PR: fix: Enable at_client to initialize in offline when network is down #1348, added feature flag to allow at_client initialize in offline access.

- How I did it

Added a preference in AtClientPreferences class. The default value is set to false to retain the existing behavior. If the flag is set to true, at_client is initialized even when network connectivity is not available.


          feat: Add feature flag to allow atClient for offline access

c477d7c

sitaram-kalluri requested review from murali-shris and gkc

July 22, 2024 05:42

Contributor

gkc commented Jul 22, 2024

@sitaram-kalluri As discussed, let's close this PR as unnecessary.

gkc closed this

gkc deleted the add_offline_access_feature_flag branch

July 22, 2024 09:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet