Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump lints from 5.0.0 to 5.1.0 in /packages/dart/sshnoports in the pub group across 1 directory #1617

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 12, 2024

Bumps the pub group with 1 update in the /packages/dart/sshnoports directory: lints.

Updates lints from 5.0.0 to 5.1.0

Release notes

Sourced from lints's releases.

package:lints v5.1.0

Changelog

Sourced from lints's changelog.

5.1.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the pub group with 1 update in the /packages/dart/sshnoports directory: [lints](https://github.com/dart-lang/lints).


Updates `lints` from 5.0.0 to 5.1.0
- [Release notes](https://github.com/dart-lang/lints/releases)
- [Changelog](https://github.com/dart-lang/lints/blob/main/CHANGELOG.md)
- [Commits](dart-lang/lints@v5.0.0...v5.1.0)

---
updated-dependencies:
- dependency-name: lints
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: pub
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dart Pull requests that update Dart code Dependency Issue requires team to address dependency labels Dec 12, 2024
@cpswan cpswan marked this pull request as draft December 12, 2024 07:03
@cpswan
Copy link
Member

cpswan commented Dec 12, 2024

We need to ensure Dart updates before merging this

@cpswan cpswan marked this pull request as ready for review December 12, 2024 07:49
@cpswan cpswan marked this pull request as draft December 12, 2024 08:03
@cpswan
Copy link
Member

cpswan commented Dec 12, 2024

E2e tests are failing because they're not (yet) getting Dart 3.6

@cpswan
Copy link
Member

cpswan commented Dec 12, 2024

Here's the error from e2e tests:

The current Dart SDK version is 3.5.0.
Because lints 5.1.0 requires SDK version ^3.6.0-0 and no versions of lints match >5.1.0 <6.0.0, lints ^5.1.0 is forbidden.
So, because sshnoports depends on lints ^5.1.0, version solving failed.
You can try one of the following suggestions to make the pubspec resolve:
* Try using the Dart SDK version: 3.6.0. See https://dart.dev/get-dart.
* Consider downgrading your constraint on lints: dart pub add dev:lints:^5.0.0
2024-12-12 07:57:31.783 | ERROR: Failed to set up binaries - exiting
2024/12/12 07:57:31 Process exited with status 1
Error: Process completed with exit code 1.

One concern here is that it's Dart 3.5.0 rather than 3.5.4 so not up to date with patch releases.

@cpswan cpswan marked this pull request as ready for review December 12, 2024 10:42
@cpswan cpswan merged commit e7bd827 into trunk Dec 12, 2024
9 checks passed
@dependabot dependabot bot deleted the dependabot/pub/packages/dart/sshnoports/pub-dde108afc0 branch December 12, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code Dependency Issue requires team to address dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant