-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode.previewHtml is deprecated. Need to be replaced with Webview API #23
Comments
muojp
changed the title
vscode.previewHtml deprecated
vscode.previewHtml is deprecated. Need to be replaced with Webview API
Mar 20, 2019
A memo after reading https://code.visualstudio.com/api/extension-guides/webview . A quick review of current design:
What Webview API requires:
In short, we would need to adopt Webview like this way:
|
Wow, thanks for the note. I'll take a look hopefully tonight or in a few days. |
okay, after a quick look, this is going to be annoying :p |
atsushieno
added a commit
that referenced
this issue
Mar 21, 2019
It requires not a small amount of refactoring...
Fixed. Thanks for the report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
VSCode warns us that vsccode-language-review uses deprecated preview API.
VSCode: 1.32.2
The text was updated successfully, but these errors were encountered: