Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFastEnumerationState is not supported By Linux #30

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

benoit-pereira-da-silva

This fix suspends BridgedList's countByEnumerating func on Linux.

@codecov
Copy link

codecov bot commented Jan 20, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@8343537). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #30   +/-   ##
========================================
  Coverage          ?   8.16%           
========================================
  Files             ?      16           
  Lines             ?    4015           
  Branches          ?      43           
========================================
  Hits              ?     328           
  Misses            ?    3681           
  Partials          ?       6
Impacted Files Coverage Δ
Sources/BridgedList.swift 0% <ø> (ø)
Sources/List.swift 14.28% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8343537...2316b1a. Read the comment docs.

@lorentey
Copy link
Collaborator

@benoit-pereira-da-silva Thank you! Could you please remove the extra commits? Codable support should go in a separate PR.

@seivan
Copy link

seivan commented Jul 13, 2018

Sorry for hijacking this PR for asking this, but is the idea to keep compatibility with Linux or will that just be an after thought? Is there a CI that runs this in Linux as well to make sure it always works?

@lorentey
Copy link
Collaborator

Hi @seivan; I sent an invite with commit access. Thank you for volunteering to do this!

@seivan
Copy link

seivan commented Jul 13, 2018

@lorentey I Didn't, but I could look into it after seeing how Map performs compared to a Dictionary for my use-case on Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants