Fix: Texture offset/tiling values getting lost when switching to other shaders #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for this contribution! As far as I remember, the _MainTex_ST is used for all textures throughout. Clearly this limitation should be re-evaluated, but it works for most models and keeps the shaders simple (and doesn't add shader variants). |
atteneder
approved these changes
Feb 19, 2021
atteneder
added a commit
that referenced
this pull request
May 27, 2024
…aternion`. (#140) * doc: Fixed duplicate headline. * feat: `float4x4.Decompose` overload that outputs rotation as type `quaternion`. * Deprecated `float4x4.Decompose` overload that outputs rotation as type `float4` (quaternion values).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already an improvement, but there are some open questions: