Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/7.1 #109

Merged
merged 5 commits into from
Nov 29, 2024
Merged

Update/7.1 #109

merged 5 commits into from
Nov 29, 2024

Conversation

Alluneve
Copy link
Contributor

@Alluneve Alluneve commented Nov 15, 2024

Welcome to 7.1.
ClientStructs had shit hit the fan, so I had to be patient.

Did version updates, verified functionality, and applied necessary changes.

edit: verified functionality means I went through all the scenarios in REGRESSIONTESTS.MD and they all pass

jeroen -local added 4 commits November 12, 2024 09:43
…n. so i'm parking fixing stuff until it does not blow up my game every time i try to open my menu because all the ingame sheets are broken and the structs do not work
 GroundTargetQueuePatch is still the same SIG (yey!)
 And applied the new lumina version and dalamud changes
@icesharkk
Copy link

mod author seems MIA. is there a way for me to get this branch working?

@Alluneve
Copy link
Contributor Author

The author is not missing in action, just be patient.

Baylee will get to this pull request someday, probably within a week or 2.

Officially a plugin is only considered abandoned if not updated for 4-6 months after a dalamud Api bumb, as per dalamud adoption policy.

The level of impatience expressed by the people using this or xiv combo is frankly not that nice, we're not paid to do maintain this and it's our free time.

@icesharkk
Copy link

impatience yes, but im not upset or anything. i dont expect them to have completed all this free work already. hence why i posted here seeing if there was a way to for me move onto the branch you have. was not trying to throw shade at the author.

@Alluneve
Copy link
Contributor Author

if you need to ask how to get code from a GitHub to local, then build it yourself to run a dev plugin in Dalamud for testing something before it's generally available in a testing release you can just get through the plugin manager, then you're probably not the audience for even attempting to do so.

before general availability, the only people who I don't mind "getting it early" are those who are at least technical enough to analyze logs properly and can already halfway pinpoint the source of an issue if an issue arrives that's not: "it doesn't work". and then at least open an issue or notify me of the problem.

so please just be patient, general availability will be there soon ™

@Alluneve
Copy link
Contributor Author

Stuff done today was some house cleaning and changing some ToString() calls into ExtractText() calls on items of type ReadyOnlySeString. because it's less heavy to turn a readOnlySePayoadSpan into text that way than to do it with the StringBuilder....

had to force-push because I didn't have my full source at lunch and needed to verify what I did this evening

@attickdoor
Copy link
Collaborator

ty fam

@attickdoor attickdoor merged commit 77703d8 into Infiziert90:master Nov 29, 2024
@Alluneve
Copy link
Contributor Author

always a pleasure

@Alluneve Alluneve deleted the Update/7.1 branch December 1, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants