Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.1 Support #360

Merged
merged 2 commits into from
Nov 29, 2024
Merged

7.1 Support #360

merged 2 commits into from
Nov 29, 2024

Conversation

natis1
Copy link
Contributor

@natis1 natis1 commented Nov 14, 2024

No description provided.

@GanjiyevR
Copy link

built this to test and it doesn't work? need to shift to the new API to update for 7.1

@Glorou
Copy link

Glorou commented Nov 18, 2024

I've built it and it works, you need to update the Dalamud Packager nuget package.

@natis1
Copy link
Contributor Author

natis1 commented Nov 18, 2024

Yes, sorry, I did not commit any changes to csproj because I locally changed the folders it was compiling from. I will commit those now.

@Glorou
Copy link

Glorou commented Nov 18, 2024

I've been trying to get a hold of @attickdoor to merge this for wider testing to no avail, but I've been using it for a day with no issues

@weyway
Copy link

weyway commented Nov 19, 2024

It seems to be working. 👍

@Zolerii1
Copy link

Sorry if this isn't the place to ask but im confused on if xivcombo now works in 7.1? in the installer it still says outdated but people hear seem to be able to use it, is there something im missing? thank you for any advice at all

@Alluneve
Copy link

@Zolerii1 no, this is not officially XIVCombo working. this is an ask by a non-plugin owner to "pretty please" add these changes to the main plugin, saying that those changes make it work for 7.1

also @Glorou, please do not pester AttickDoor for a merge. be patient, I'll come when it'll come.

@Rajsen123
Copy link

just wanted to ask any1 who have successfully compiled the updated version for test cud share repo url so i can use it while attick is busy. sry to impose but i have limited mobitlity in my hands and the plugin will really help me enjoy the game. just a dev experimental plugin or url to a workin solution will do until attick updates the plugin. really sry but it wud really help.

@Alluneve
Copy link

Alluneve commented Nov 24, 2024

@Rajsen123

if you need to ask how to get code from a GitHub to local, then build it yourself to run a dev plugin in Dalamud for testing something before it's generally available in a testing release you can just get through the plugin manager, then you're probably not the audience for even attempting to do so.

Before general availability, the only people who I don't mind "getting it early" are those who are at least technical enough to analyze logs properly and can already halfway pinpoint the source of an issue if an issue arrives that's not: "it doesn't work". and then at least open an issue or notify me of the problem.

So please just be patient, general availability will be there soon ™

this quote from this other pull request applies here

also to quote from the Dalamud Discord itself:
afbeelding

"Please just be patient, General Availability will be there soon ™"

@Bellidrael
Copy link

I mean I'm seeing comments like, from you:

"The level of impatience expressed by the people using this or xiv combo is frankly not that nice, we're not paid to do maintain this and it's our free time."

And obviously, I'm not a coder, I have no idea what's going on, but from what I can tell... the whole point of this thread here is that someone has effectively already fixed the plugin to work with 7.1, and all that has to be done is to update the plugin with this fix and the plugin will work.

However despite how simple that sounds, and I'm sure there's a least a bit more to it than that... this change has been here, ready to use, for 2 weeks. And yet we are being told it'll 'maybe' be fixed and useable in 'a week or two'.

Meanwhile plugins like Wrath Combo (Which I don't really want to use because it legitimately feels like cheating) were updated within days of Dalamud being back up and running, and it's by far a more complex plugin.

So really, I know it isn't your duty to do so, and I have no right to demand it, but I think people would relax a bit if the information on what exactly takes so long to update the plugin was more readily available.

Because from the perspective of people like me, it looks like a fix has been ready for 2 weeks and the plugin dev just hasn't even bothered to log in and press the button.

There's a fine line between 'impatience' and wondering why we have to wait a month for a plugin to be updated to a new version, when most of the other plugins are working just fine already. None of this is intended to be rude, but rather, many of us really like this mod, and our characters are set up to use this mod, and we can't play certain jobs without either using this mod, or completely redoing our bars, something we would rather not do. And we would just like more information than 'be patient' and 'soon'.

Eventually, the question comes to, if this is such a low priority that weeks can go by with a fix readily available, but not being merged because 'We do this during our free time'... then at what point do you just pass it on to a different dev who is willing to be more proactive in keeping it updated?

Again, I have no clue what I'm talking about here. I don't know if it is just as simple as pressing the merge button and bam we have a working plugin. But that's a part of the problem, and a reason why people get impatient with these things. We are clueless gamers just wanting a plugin we like to work, and don't understand why so much time has passed without it working.

It's kinda like, we appreciate you guys giving up some free time to work on these plugins and make them publicly available for everyone to use. But at the same time, 2 weeks of no news, really? And potentially 2 more weeks before we get anything working? It just seems a bit much.

@RecklessRemi
Copy link

No offense, but they have the right to say everything that's been stated. This is close enough to a holiday for most people to be traveling or doing things with family.

If a plug in helps you play, that's cool. However, your entire gaming experience should not be centered on one plugin. You yourself are limiting yourself from playing. Create a hot bar for an extremely low button bloat job to play (Viper or Picto for example) and play content with those for the time being.

Let the dev author and team figure it out. Cool, these guys found something and it /seems/ to be working. Seems to be working and officially declared as working flawlessly are two different things.

Please be patient, play other games, etc while this is down. Might I suggest playing Throne and Liberty a game with an extremely tiny hot bar.

@Alluneve
Copy link

Alluneve commented Nov 25, 2024

As the owner of a plugin, you have certain rights regarding your plugin.
the only caveat to your own plugin is that if they end up on the main plugin repository, you agree to the adoption policy.

As long as you own the plugin, you are in your right to providing a new release or update to it at your own discretion.
As long as it's within the SLA time window of the adoption policy, you're well within your right to provide an update until the very last day.

for the record:
The plugin has fallen behind the current API level for over three months. You have made reasonable efforts to reach the original developer. is the soft deadline for updating any plugin on the main repository.
We're currently 5 days since Dalamud officially released on API level 11.

If Attick wanted to, they could wait until February 19, 2025, before falling into this clause.

now please be patient, sit down, and relax.
Else, with a wink and a smile, the update on XivCombo could be maliciously delayed until February 2025

@weyway
Copy link

weyway commented Nov 25, 2024

Pretty much wait for it to be updated officially if your investment in this is only as an end-user.

Nobody will get you a plug-and-play solution, and to be honest neither should you accept one, because if you don't know what's in there, this is code, it could be doing something else you don't really want it doing. 😉

The other way around it, is learning how it works and get your own testing version working yourself. It's not as easy as just updating it on dalamud, but learning new things is never wasted and it would give you a different insight into how things work on the other side. 😋

@Azymondias
Copy link

i honestly dont mind the waiting, but it would be nice to atleast have some news about the updating process and how its faring :)

@attickdoor
Copy link
Collaborator

oops

@attickdoor attickdoor merged commit 53f61f0 into MKhayle:master Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.