Sample of deprecating EOL support, updating test wrapper #413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is admittedly applying a hammer. The result is being able to locally:
rbenv
installed./test/run.sh
with some modern Ruby and ActiveRecord versionsThis led to removal of a few things:
datamapper
is now deprecated https://stackoverflow.com/questions/18153839/can-datamapper-still-be-used-for-railsfind_by
methods are deprecated from ActiveRecordattr_protected
is also deprecated and removed from ActiveRecordattribute_was
is also no longer valid sine ActiveRecord renamed a bunch of methods, per There is a missing release note about AR::Dirty methods changed inside of after_(create|update|save) callbacks rails/rails#36874Additionally, incorporated the below two commits manually for example (we should approve and merge those folks PRs as I don't intend to merge this as is)
Given the lack of maintenance the last few years this is a lot of changes and feels aggressive, I'll admit. I wanted to guage feedback from folks, and unless there is great pushback, start work towards:
Appraisal
to not conditionalize theActiveRecord
gem requirement in the gemspec