Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample of deprecating EOL support, updating test wrapper #413

Closed
wants to merge 1 commit into from

Conversation

joshbranham
Copy link
Member

This is admittedly applying a hammer. The result is being able to locally:

  • With rbenv installed
  • Run ./test/run.sh with some modern Ruby and ActiveRecord versions

This led to removal of a few things:

Additionally, incorporated the below two commits manually for example (we should approve and merge those folks PRs as I don't intend to merge this as is)

Given the lack of maintenance the last few years this is a lot of changes and feels aggressive, I'll admit. I wanted to guage feedback from folks, and unless there is great pushback, start work towards:

  • New major version with support for ActiveRecord and Sequel where we can test sanely
  • Utilize Appraisal to not conditionalize the ActiveRecord gem requirement in the gemspec
  • Either talk to Travis for more credits or just switch to CircleCI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant