Remove '@' from sender_name #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In older versions of the API the sender_name didn't include this. Because it now does this will remove it when it does but still add it afterwards. This way it doesn't break compatibility with older api versions and we don't have to verify it. Signed-off-by: Patrick Guilbert <patrick.pollo.guilbert@gmail.com>
|
Code Climate has analyzed commit 7018a0e and detected 0 issues on this pull request. View more on Code Climate. |
|
@attzonko you tell me if this is fine or if there is a better way! Currently that's what we manually edited on our server version of the bot running. |
epatpol
changed the title
epatpol
changed the title
|
Fixes #118 |
|
Thanks for the quick fix. |
sheiun
added a commit
to ap-mic/mmpy_bot
that referenced
this pull request
Dec 1, 2019
attzonko
pushed a commit
that referenced
this pull request
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In older versions of the API the sender_name didn't include this.
Because it now does this will remove it when it does but still add it
afterwards. This way it doesn't break compatibility with older api
versions and we don't have to verify it.
Signed-off-by: Patrick Guilbert patrick.pollo.guilbert@gmail.com