Introduce @at_start #135
Merged
Introduce @at_start #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit d5cdfb0 and detected 0 issues on this pull request. View more on Code Climate. |
|
Thanks for adding this capability. I am sure it will come in handy for many people. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@at_startaddresses the use-case from #132.The interface is rather low level and a little fragile compared to the other decorators.
Currently it grants direct access to the
MattermostClientobject and indirectlyMattermostAPI. The choice forclient` stems from the need for flexibility when crafting a message.From what I gathered, the current code is missing a high level interface that isn't tied to incoming messages, something for another pull request...
I also include a few commits addressing minor code and documentation issues.