Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: clap3.0.0-rc.7 #233

Closed
wants to merge 2 commits into from
Closed

WIP: clap3.0.0-rc.7 #233

wants to merge 2 commits into from

Conversation

conradludgate
Copy link
Collaborator

@conradludgate conradludgate commented Dec 10, 2021

clap 3.0.0 is going into official release soon, with that comes the long awaited removal of structopt

Waiting on clap-rs/clap#2869

@conradludgate
Copy link
Collaborator Author

Screenshot from 2021-12-10 17-20-07

Output compared from clap3 to the current structopt impl. Last test shows aliases still working

@conradludgate
Copy link
Collaborator Author

Small regression using InferSubcommands is that you cannot specify how to resolve ambiguous cases.

Originally, we supported atuin history l to be atuin-history-list and atuin history la to be atuin-history-last. The InferSubcommands setting just makes the base case an error

@pksunkara
Copy link

For those kind of conflict, alias will have to do. So add l as alias to list.

@conradludgate
Copy link
Collaborator Author

conradludgate commented Dec 16, 2021

@ellie it's wholesome that my first PR here #1 was using structopt instead of clap and very soon we'll be reverting that 😅

@ellie
Copy link
Member

ellie commented Dec 16, 2021

@ellie it's wholesome that my first PR here #1 was using structopt instead of clap and very soon we'll be reverting that 😅

Awww I love that haha! Come full circle 😁

@conradludgate conradludgate changed the title WIP: clap3.0.0-rc.3 WIP: clap3.0.0-rc.7 Dec 19, 2021
@conradludgate
Copy link
Collaborator Author

Just rebased and updated to the lastest release candidate (rc7), as well as merge in support for shell completions (addressing #249)

panekj added a commit to panekj/atuin that referenced this pull request Feb 6, 2022
based on: atuinsh#233

Co-authored-by: Jakub Panek <me@panekj.dev>
@conradludgate
Copy link
Collaborator Author

Remind me to complete this

@panekj
Copy link
Contributor

panekj commented Apr 12, 2022

reminder that this can be closed due to #289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants