feat: add an inline view mode

[pdecat]

• Use crossterm and inline viewport
• Reposition cursor on exit and fix The cursor position could not be read within a normal duration errors due to blocking reads

[pdecat]

Partly duplicate of #331 for the crossterm changes.

[ellie]

Hey @pdecat! Thanks for the work here - once #331 is merged, would we be able to keep the inline view from here?

I think I'd like to make it the default for "up" arrow bindings

[pdecat]

That's the plan 🙂

[pdecat]

Left a comment on https://github.com/ellie/atuin/pull/331/files#r1100358866 to determine the best way to backport fdehau/tui-rs#552.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
atuin	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 25, 2023 at 4:24PM (UTC)

[conradludgate]

The diff is now so smol 😄

[pdecat]

Awesome, thanks @conradludgate!

I'll try and take another look at finishing this PR ASAP. Feel free to to hack on it if you like :)

[pdecat]

Looks like this is actually working great in its current state.

I guess what's left to do is to make this new behaviour optional, isn't it?

Also, being able to configure the number of lines would be great too.

[ellie]

Looks like this is actually working great in its current state.

I guess what's left to do is to make this new behaviour optional, isn't it?

Also, being able to configure the number of lines would be great too.

It does! I've been using it since last night. Started to make it configurable but my parents are visiting this weekend so haven't finished 🤣

1. Make it optional
2. Configure the number of lines
3. Release! 🚀

I think it would also feel a bit better if the search box was at the top for inline mode, but that can wait - I'd like to make the whole UI more configurable

[pdecat]

Added an inline_height setting which can be used to define the number of lines to use in inline mode.
When setting it to zero (the default), inline mode is disabled.

Maybe the naming could be improved.

@conradludgate @ellie WDYT?

[pdecat]

Started to make it configurable but my parents are visiting this weekend so haven't finished

@ellie oops, read that part of your reply too fast, I didn't realize you actually started implementing the setting, sorry about that.

Feel free to scratch my version if you prefer yours.

[pdecat]

Working on putting the input chunk at the top when inline mode is active...

Edit: I believe it also means reversing the history list direction, which means more work needed. Will open another PR.

[conradludgate]

We can merge as is, I like it. We can fix the UI later. I've been daily driving for a few days and it still feels pretty nice

[pdecat]

Good for me! :)

Submitted #808 as a draft, will have to come back to it at a later time.

[conradludgate]

No worries! Thank you for your efforts. They are really appreciated

[ellie]

LGTM! Thank you so much for this, it's a huge improvement <3