Add --offset flag to atuin search
#825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
We moved to using a struct for a bunch of these options - the function signature was getting pretty large! I like this change though, will allow third party integrations some more flexibility. Happy to approve once we've got it rebased! |
This flag allows the user to continue searching at an offset. This is useful for building tools that use atuin to search for previous commands and return only one result. ``` atuin search --limit 1 atuin search --limit 1 --offset 1 atuin search --limit 1 --offset 2 ```
takac
force-pushed
the
search-with-offset
branch
from
f60d692 to
6356327
Compare
|
Oh hang on - I always forget this 🤦♀️ would you be able to update the docs with this as well please? 🙏 https://github.com/ellie/atuin/blob/main/docs/docs/commands/search.md |
|
Sure, will follow up on that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag allows the user to continue searching at an offset. This is useful for building tools that use atuin to search for previous commands and return only one result.