Update get_data_gov_lt.in #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sirex
reviewed
Mar 22, 2022
sirex
reviewed
Mar 22, 2022
| ,datasets/gov/lhmt/klimatologiniai_duomenys,,,,,,,,,,,,, | ||
| ,,,,,,,,,,,,,, | ||
| ,,,,MeterologinesAiksteles,,,,,,,,,, | ||
| ,,,,,meterologines_aikst_adr,string,,,,3,open,,Meterologinės aikštelės adresas, |
There was a problem hiding this comment.
Suggested change
| ,,,,,meterologines_aikst_adr,string,,,,3,open,,Meterologinės aikštelės adresas, | |
| ,,,,,meterologines_aikst_adr,ref,datasets/gov/rc/ar/patalpa/Patalpa,,,2,open,,Meterologinės aikštelės adresas, |
sirex
reviewed
Mar 22, 2022
sirex
reviewed
Mar 22, 2022
| ,,,,,,,,,,,,,, | ||
| ,,,,VandensMatavimoStotys,,,,,,,,,, | ||
| ,,,,,vms,string,,,,3,open,,vandens matavimo stotis, | ||
| ,,,,,vand_telk_pvd,string,,,,3,open,,vandens telkinio pavadinimas, |
There was a problem hiding this comment.
Suggested change
| ,,,,,vand_telk_pvd,string,,,,3,open,,vandens telkinio pavadinimas, | |
| ,,,,,vand_telk_pvd,ref,?,,,3,open,,vandens telkinio pavadinimas, | |
| ,,,,,ats_nuo_ziociu,number,,,,3,open,,"atstumas nuo žiočių, km", | ||
| ,,,,,koord_x,geometry,,,,4,open,,vandens matavimo stoties koordinatės x (WGS), | ||
| ,,,,,koord_y,geometry,,,,4,open,,vandens matavimo stoties koordinatės y (WGS), | ||
| ,,,,,isteigta,integer,,,,3,open,,vandens matavimo stoties įsteigimo metai, |
There was a problem hiding this comment.
Suggested change
| ,,,,,isteigta,integer,,,,3,open,,vandens matavimo stoties įsteigimo metai, | |
| ,,,,,isteigta,date,Y,,,4,open,,vandens matavimo stoties įsteigimo metai, |
| ,,,,,koord_y,geometry,,,,4,open,,vandens matavimo stoties koordinatės y (WGS), | ||
| ,,,,,isteigta,integer,,,,3,open,,vandens matavimo stoties įsteigimo metai, | ||
| ,,,,,vand_telk_tipas,string,,,,3,open,,vandens telkinio tipas, | ||
| ,,,,,geohash,string,,,,3,open,,X ir Y koordinačių kombinacija vizualizavimui, |
There was a problem hiding this comment.
| ,,,,,aukst_virs_jur_lygio,number,,,,3,open,,Vandens aukštis virš jūros lygio , | ||
| ,,,,,koord_x,geometry,,,,4,open,,meterologinės aikštelės koordinatės x (WGS), | ||
| ,,,,,koord_y,geometry,,,,4,open,,meterologinės aikštelės koordinatės y (WGS), | ||
| ,,,,,isteigta,integer,,,,3,open,,Matavimo stoties įsteigimo metai, |
There was a problem hiding this comment.
Suggested change
| ,,,,,isteigta,integer,,,,3,open,,Matavimo stoties įsteigimo metai, | |
| ,,,,,isteigta,date,Y,,,4,open,,Matavimo stoties įsteigimo metai, |
Co-authored-by: Mantas Zimnickas <sirexas@gmail.com>
Co-authored-by: Mantas Zimnickas <sirexas@gmail.com>
Co-authored-by: Mantas Zimnickas <sirexas@gmail.com>
Co-authored-by: Mantas Zimnickas <sirexas@gmail.com>
Co-authored-by: Mantas Zimnickas <sirexas@gmail.com>
sirex
reviewed
Mar 22, 2022
datasets/gov/lhmt/hidrologija.csv
Outdated
| ,,,,,vand_telk_pvd,string,,,,3,open,,vandens telkinio pavadinimas, | ||
| ,,,,,ats_nuo_ziociu,number,,,,3,open,,"atstumas nuo žiočių, km", | ||
| ,,,,,koord,"geometry(point,4326)",m,,,4,open,,vandens matavimo stoties koordinatės (WGS), | ||
| ,,,,,koord_wkt,geometry,m,,,4,open,,Meterologinės aikštelės koordinatės WKT formatu, |
There was a problem hiding this comment.
Užtenka tik koord, visais atvejais, kai naudojamas geometry tipas, duomenys perduodami WKT formatu. Todėl šitą eilutę reikėtų trinti.
datasets/gov/lhmt/hidrologija.csv
Outdated
| ,,,,,koord_wkt,geometry,m,,,4,open,,Meterologinės aikštelės koordinatės WKT formatu, | ||
| ,,,,,isteigta,integer,,,,3,open,,vandens matavimo stoties įsteigimo metai, | ||
| ,,,,,vand_telk_tipas,string,,,,3,open,,vandens telkinio tipas, | ||
| ,,,,,geohash,string,,,,3,open,,X ir Y koordinačių kombinacija vizualizavimui, |
There was a problem hiding this comment.
Šitos eilutės netrinsi? Nes, kaip ir minėjau geohash galima išskaičiuoti iš koord.
datasets/gov/lhmt/klimatologija.csv
Outdated
| ,,,,,mat_stotis,string,,,,3,open,,Matavimo stoties pavadinimas, | ||
| ,,,,,aukst_virs_jur_lygio,number,,,,3,open,,Vandens aukštis virš jūros lygio , | ||
| ,,,,,koord,"geometry(point,4326)",m,,,4,open,,Meterologinės aikštelės koordinatės (WGS), | ||
| ,,,,,koord_wkt,geometry,m,,,4,open,,Meterologinės aikštelės koordinatės WKT formatu, |
There was a problem hiding this comment.
Šis laukas nereikalingas, nes jis yra toks pat, kaip koord.
datasets/gov/lhmt/klimatologija.csv
Outdated
| ,,,,,koord,"geometry(point,4326)",m,,,4,open,,Meterologinės aikštelės koordinatės (WGS), | ||
| ,,,,,koord_wkt,geometry,m,,,4,open,,Meterologinės aikštelės koordinatės WKT formatu, | ||
| ,,,,,isteigta,integer,,,,3,open,,Matavimo stoties įsteigimo metai, | ||
| ,,,,,geohash,string,,,,3,open,,X ir Y koordinačių kombinacija vizualizavimui, |
There was a problem hiding this comment.
Tas pats komentaras, kaip ir aukščiau.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.