-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for text type #304
Conversation
It is possible to use text type in manifest files, write and read to/from database. Added tests for html format, but could not easilly get it show `name@lang`, now it shows `name.lang`. Didn't tested it with on changelog, didn't tested how patch and changelog works. Didn't tested if it is able to read and push text type from external sources.
957350f
to
1fb9dc3
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are multiple errors see my notes in notes/types/text.sh
.
Pasitikslinau su Mantu, tai ne `array` tipo duomenys. Tai `text` tipo duomenys. Primenu, kad `text` nepalaikomas, todėl esame sutarę, kad žymime `string` ir nurodome 4 brandos lygį. atviriduomenys/spinta#304
There might be a problem for type push chunks, could not write a decent test and for just added skip wrapper for them. I might be wrong but it seems in our case its not possible to create jsonb format, Also it turn out that some tests were failing because of this commit I looked and master branch and rollback like it was in master (probably override it when merging) |
From given example: @pytest.fixture(scope='module')
def geo_db_for_text():
with create_sqlite_db({
'salis': [
sa.Column('id', sa.Integer, primary_key=True),
sa.Column('kodas', sa.Text),
sa.Column('pavadinimas', sa.dialects.postgresql.JSONB),
],
'miestas': [
sa.Column('id', sa.Integer, primary_key=True),
sa.Column('pavadinimas', sa.Text),
sa.Column('salis', sa.dialects.postgresql.JSONB),
],
}) I see, that you are trying to pass PostgreSQL JSONB column type, to an SQLite database, this will not work, you can't use column types from other dialects, here you must use SQLite types. I'm not sure, what you are trying to achieve here, but if you try to store |
# Conflicts: # spinta/backends/postgresql/commands/query.py # spinta/manifests/tabular/helpers.py # tests/datasets/csv/test_read.py
# Conflicts: # tests/cli/test_push.py
No description provided.