Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check dataset, model and property names. #327

Merged
merged 10 commits into from
Nov 24, 2023
Merged

Check dataset, model and property names. #327

merged 10 commits into from
Nov 24, 2023

Conversation

Gediminas-msc
Copy link
Contributor

No description provided.

@Gediminas-msc Gediminas-msc linked an issue Nov 17, 2022 that may be closed by this pull request
Check dataset, model and property names #158
Open
7 tasks
sirex
sirex requested changes Nov 28, 2022
View reviewed changes
spinta/datasets/commands/check.py Outdated Show resolved Hide resolved
spinta/cli/config.py Outdated Show resolved Hide resolved
spinta/core/config.py Outdated Show resolved Hide resolved
spinta/core/config.py Outdated Show resolved Hide resolved
spinta/datasets/commands/check.py Outdated Show resolved Hide resolved
spinta/datasets/commands/check.py Outdated Show resolved Hide resolved
spinta/datasets/commands/check.py Outdated Show resolved Hide resolved
spinta/datasets/commands/check.py Outdated Show resolved Hide resolved
spinta/datasets/commands/check.py Outdated Show resolved Hide resolved
spinta/datasets/commands/check.py Outdated Show resolved Hide resolved
sirex
sirex requested changes Dec 2, 2022
View reviewed changes
spinta/cli/config.py Outdated Show resolved Hide resolved
spinta/core/config.py Outdated Show resolved Hide resolved
spinta/datasets/commands/check.py Outdated Show resolved Hide resolved
spinta/datasets/commands/check.py Outdated Show resolved Hide resolved
spinta/types/helpers.py Outdated Show resolved Hide resolved
spinta/types/helpers.py Outdated Show resolved Hide resolved
spinta/types/helpers.py Outdated Show resolved Hide resolved
sirex
sirex requested changes Dec 2, 2022
View reviewed changes
spinta/config.yml Outdated Show resolved Hide resolved
spinta/core/config.py Outdated Show resolved Hide resolved
spinta/core/config.py Outdated Show resolved Hide resolved
spinta/cli/config.py Outdated Show resolved Hide resolved
spinta/types/helpers.py Outdated Show resolved Hide resolved
sirex
sirex requested changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@sirex sirex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests, and test datasets, model, property names and error messages, add test if single letter names are allowed, add tests for invalid cases.

spinta/types/helpers.py Show resolved Hide resolved
@sirex sirex force-pushed the 158-check-dataset-model-and-property-names branch from 37028ce to 7426e71 Compare November 24, 2023 08:00
@sirex sirex merged commit 5efe352 into master Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirex sirex sirex requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check dataset, model and property names
2 participants
@Gediminas-msc @sirex