149 push ref dependencies #415
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current push implementetion can't resolve circular dependencies. Also, current implementation reads all rows from source table, which can lock table. New implementation: - will read rows one by one using threads; - each read can be postponed if dependencies are not yet pushed; - source tables will be read in small chunks; - there will be no need to set_matadata scope since _id's will be taken from target data store. Fixes: - #149
…149-push-ref-dependencies # Conflicts: # tests/test_push.py
sirex
requested changes
Jul 26, 2023
| data_with_self_reference[payload.get("_id")] = { | ||
| "data": data, | ||
| "self_reference": filtered_properties | ||
| } |
There was a problem hiding this comment.
Unfortunately this won't work with large datasets, because as I understand, here all table data is loaded into memory and then sorted?
But of course this would be a good solution if all datasets would fit into memory.
If data would be sorted using SQL query this would work. But in order to sort data using SQL we need a recursive CTE, see https://stackoverflow.com/questions/59137122/sql-query-for-topological-sort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.