475 added acceptable content types #498
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sirex
requested changes
Aug 2, 2023
| from spinta.commands.write import write | ||
| store = prepare_manifest(context) | ||
| manifest = store.manifest | ||
| root = manifest.objects['ns'][''] |
There was a problem hiding this comment.
I'm not sure if access rights are checked here? We should limit client to only write to a specified namespace or model. And here, we just take root namespace, which probably gives permission to write data to any namespace?
# Conflicts: # spinta/commands/write.py # spinta/datasets/backends/csv/components.py # spinta/datasets/backends/helpers.py # spinta/formats/helpers.py
sirex
reviewed
Dec 7, 2023
sirex
reviewed
Dec 7, 2023
| else: | ||
| stream = _read_request_body( | ||
| context, request, scope, action, params, stop_on_error, | ||
| ) |
sirex
reviewed
Dec 7, 2023
| @@ -49,6 +52,7 @@ | |||
| STREAMING_CONTENT_TYPES = [ | |||
| 'application/x-jsonlines', | |||
| 'application/x-ndjson', | |||
| 'application/json' | |||
There was a problem hiding this comment.
application/json should not be here, this is not a streaming content type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.