Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hotswapping methods forApiV1() and forApiV2() #357

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

reliq
Copy link
Collaborator

@reliq reliq commented Apr 27, 2021

Follow-up to finally fix #355

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #357 (5b0aacc) into main (1544d8b) will increase coverage by 2.52%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #357      +/-   ##
============================================
+ Coverage     34.39%   36.91%   +2.52%     
  Complexity      361      361              
============================================
  Files            32       32              
  Lines           814      818       +4     
============================================
+ Hits            280      302      +22     
+ Misses          534      516      -18     
Impacted Files Coverage Δ Complexity Δ
src/Concern/HotSwapper.php 100.00% <100.00%> (+52.63%) 4.00 <3.00> (ø)
src/ApiV1/Service/Twitter.php 50.00% <0.00%> (+40.00%) 8.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1544d8b...5b0aacc. Read the comment docs.

@reliq reliq merged commit 738a2b5 into main Apr 27, 2021
@reliq reliq deleted the fix-unable-to-switch-api-version-2 branch April 27, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't switch instance from v1 to v2
1 participant