Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose new tweet count endpoints, ref: #365 #366

Merged
merged 3 commits into from
Jun 28, 2021
Merged

Expose new tweet count endpoints, ref: #365 #366

merged 3 commits into from
Jun 28, 2021

Conversation

reliq
Copy link
Collaborator

@reliq reliq commented Jun 27, 2021

The changes herein:

  1. expose the new tweet count endpoints
  2. add notes and example on how to use newly added v2 endpoint

ref: #365

@reliq reliq requested a review from atymic June 27, 2021 23:36
@codecov
Copy link

codecov bot commented Jun 27, 2021

Codecov Report

Merging #366 (6fabcb9) into main (f6c6d6d) will increase coverage by 0.75%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #366      +/-   ##
============================================
+ Coverage     36.70%   37.45%   +0.75%     
- Complexity      365      367       +2     
============================================
  Files            32       33       +1     
  Lines           831      841      +10     
============================================
+ Hits            305      315      +10     
  Misses          526      526              
Impacted Files Coverage Δ
src/Service/Accessor.php 57.14% <ø> (ø)
src/Concern/TweetCounts.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6c6d6d...6fabcb9. Read the comment docs.

@atymic
Copy link
Owner

atymic commented Jun 28, 2021

Awesome job! Thanks

@atymic atymic merged commit df129e8 into main Jun 28, 2021
@atymic atymic deleted the apiv2-tweet-count branch June 28, 2021 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants