Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-add account activity trait #372

Merged
merged 3 commits into from
Jul 19, 2021
Merged

Conversation

reliq
Copy link
Collaborator

@reliq reliq commented Jul 19, 2021

This re-introduces the missing AccountActivityTrait for API v1.


issue: #368
prev. ref: #286

sykezz and others added 2 commits July 19, 2021 21:16
* Webhook functions

* Subscriptions functions

* Made app-only requests working!

* Return http response code for the requests which returns http 204

* Added documentation :)

* Requested changes

* Requested changes. StyleCI.

(cherry picked from commit 451dde9)

# Conflicts:
#	README.md
#	src/ApiV1/Traits/AccountActivityTrait.php
#	src/Thujohn/Twitter/Twitter.php
@reliq reliq requested a review from atymic July 19, 2021 19:48
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #372 (f1b1476) into main (5278f6f) will decrease coverage by 1.86%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #372      +/-   ##
============================================
- Coverage     37.45%   35.59%   -1.87%     
- Complexity      367      383      +16     
============================================
  Files            33       34       +1     
  Lines           841      885      +44     
============================================
  Hits            315      315              
- Misses          526      570      +44     
Impacted Files Coverage Δ
src/ApiV1/Service/Twitter.php 50.00% <ø> (ø)
src/ApiV1/Traits/AccountActivityTrait.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5278f6f...f1b1476. Read the comment docs.

@atymic atymic merged commit 44331ff into main Jul 19, 2021
@atymic atymic deleted the fix-account-activity-trait-missing branch July 19, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants