ADM-841: [frontend] fix: show board configuration config in metrics s…

…tep (#1111) * ADM-841: [frontend] fix: show board configuration config in metrics step * ADM-841: [frontend] fix: fix test * ADM-841: [frontend] fix: rename field * ADM-841: [frontend] fix: fix test
au-heartbeat · Mar 5, 2024 · 92a6df0 · 92a6df0
1 parent a138df4
commit 92a6df0
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 8 deletions.
diff --git a/frontend/__tests__/containers/MetricsStep/MetricsStep.test.tsx b/frontend/__tests__/containers/MetricsStep/MetricsStep.test.tsx
@@ -77,7 +77,7 @@ describe('MetricsStep', () => {
     setup();
 
     expect(screen.getByText(CREWS_SETTING)).toBeInTheDocument();
-    expect(screen.queryByText(CYCLE_TIME_SETTINGS)).not.toBeInTheDocument();
+    expect(screen.queryByText(CYCLE_TIME_SETTINGS)).toBeInTheDocument();
     expect(screen.queryByText(CLASSIFICATION_SETTING)).not.toBeInTheDocument();
     expect(screen.getByText(REAL_DONE)).toBeInTheDocument();
   });
@@ -88,7 +88,7 @@ describe('MetricsStep', () => {
     setup();
 
     expect(screen.getByText(CREWS_SETTING)).toBeInTheDocument();
-    expect(screen.queryByText(CYCLE_TIME_SETTINGS)).not.toBeInTheDocument();
+    expect(screen.queryByText(CYCLE_TIME_SETTINGS)).toBeInTheDocument();
     expect(screen.queryByText(CLASSIFICATION_SETTING)).not.toBeInTheDocument();
     expect(screen.queryByText(REAL_DONE)).not.toBeInTheDocument();
   });

diff --git a/frontend/__tests__/containers/MetricsStepper/MetricsStepper.test.tsx b/frontend/__tests__/containers/MetricsStepper/MetricsStepper.test.tsx
@@ -133,7 +133,12 @@ const fillMetricsPageDate = async () => {
     store.dispatch(saveTargetFields([{ name: 'mockClassification', key: 'mockClassification', flag: true }]));
     store.dispatch(saveUsers(['mockUsers']));
     store.dispatch(saveDoneColumn(['Done', 'Canceled'])),
-      store.dispatch(updateCycleTimeSettings([{ name: 'TODO', value: 'To do' }]));
+      store.dispatch(
+        updateCycleTimeSettings([
+          { column: 'Testing', status: 'testing', value: 'Done' },
+          { column: 'Testing', status: 'test', value: 'Done' },
+        ]),
+      );
     store.dispatch(updateTreatFlagCardAsBlock(false)),
       store.dispatch(
         updateDeploymentFrequencySettings({ updateId: 0, label: 'organization', value: 'mock new organization' }),

diff --git a/frontend/__tests__/containers/ReportStep/DoraMetrics.test.tsx b/frontend/__tests__/containers/ReportStep/DoraMetrics.test.tsx
@@ -57,7 +57,7 @@ describe('Report Card', () => {
     setup();
 
     expect(screen.getByText(RETRY)).toBeInTheDocument();
-    expect(screen.getByText('Failed to get Github info, status: 404')).toBeInTheDocument();
+    expect(screen.getByText('Failed to get GitHub info, status: 404')).toBeInTheDocument();
 
     await userEvent.click(screen.getByText(RETRY));
 

diff --git a/frontend/__tests__/containers/ReportStep/ReportStep.test.tsx b/frontend/__tests__/containers/ReportStep/ReportStep.test.tsx
@@ -509,7 +509,7 @@ describe('Report Step', () => {
       setup(REQUIRED_DATA_LIST);
 
       expect(addNotification).toBeCalledWith({
-        message: MESSAGE.FAILED_TO_GET_DATA('Github'),
+        message: MESSAGE.FAILED_TO_GET_DATA('GitHub'),
         type: 'error',
       });
     });

diff --git a/frontend/src/containers/MetricsStep/index.tsx b/frontend/src/containers/MetricsStep/index.tsx
@@ -109,7 +109,7 @@ const MetricsStep = () => {
             <>
               <Crews options={users} title={'Crew settings'} label={'Included Crews'} />
 
-              {requiredData.includes(REQUIRED_DATA.CYCLE_TIME) && <CycleTime />}
+              <CycleTime />
 
               {isShowRealDone && (
                 <RealDone columns={jiraColumns} title={'Real done setting'} label={'Consider as Done'} />

diff --git a/frontend/src/containers/ReportStep/DoraMetrics/index.tsx b/frontend/src/containers/ReportStep/DoraMetrics/index.tsx
@@ -191,7 +191,7 @@ const DoraMetrics = ({
 
   const getErrorMessage4Github = () =>
     _.get(doraReport, ['reportMetricsError', 'sourceControlMetricsError'])
-      ? `Failed to get Github info, status: ${_.get(doraReport, [
+      ? `Failed to get GitHub info, status: ${_.get(doraReport, [
           'reportMetricsError',
           'sourceControlMetricsError',
           'status',

diff --git a/frontend/src/containers/ReportStep/index.tsx b/frontend/src/containers/ReportStep/index.tsx
@@ -152,7 +152,7 @@ const ReportStep = ({ handleSave }: ReportStepProps) => {
       setNotifications4SummaryPage((prevState) => [
         ...prevState,
         {
-          message: MESSAGE.FAILED_TO_GET_DATA('Github'),
+          message: MESSAGE.FAILED_TO_GET_DATA('GitHub'),
           type: 'error',
         },
       ]);