Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ADM-733[backend]revert: expose ports to make e2e pass (#1007)" #1011

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

BoBoDai
Copy link

@BoBoDai BoBoDai commented Jan 31, 2024

This reverts commit 61439aa.

Summary

...

Before

Description

Screenshots
If applicable, add screenshots to help explain behavior of your code.

After

Description

Screenshots
If applicable, add screenshots to help explain behavior of your code.

Note

Null

Copy link

Hi @BoBoDai! 👋
Thank you for submitting a pull request! We appreciate your contribution and will review your changes as soon as possible.

@BoBoDai BoBoDai requested a review from weiraneve January 31, 2024 05:02
Copy link

codacy-production bot commented Jan 31, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (61439aa) 5533 5533 100.00%
Head commit (b3d2650) 8386 (+2853) 8386 (+2853) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1011) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@BoBoDai BoBoDai merged commit 7641b92 into main Jan 31, 2024
51 checks passed
@BoBoDai BoBoDai deleted the ADM-733-revert branch January 31, 2024 05:47
PengxiWPix pushed a commit that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants