Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADM-813[frontend/backend]: add Advance field in metrics page #1075

Merged
merged 24 commits into from
Feb 28, 2024
Merged

Conversation

TingyuDong
Copy link

@TingyuDong TingyuDong commented Feb 23, 2024

Summary

Due to board token permissions, data for 'story point' and 'block' cannot be fetched from the target field returned by the Jira API call using their token (in the covertCustomFieldKey method). Hence, the key for the corresponding custom field for story points is allowed to be set via environment variables beforehand, and the key record of the respective custom field will then be found in the return value of get real done.

Before

Could not set Advance field.

Screenshots
image

After

Could set Advance field.

Screenshots
image

Note

Null

Copy link

codacy-production bot commented Feb 23, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (31c6946) 5627 5627 100.00%
Head commit (8e6633a) 11378 (+5751) 11378 (+5751) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1075) 113 113 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link

Hi @TingyuDong! 👋
Thank you for submitting a pull request! We appreciate your contribution and will review your changes as soon as possible.

@BoBoDai BoBoDai self-requested a review February 23, 2024 02:18
@TingyuDong TingyuDong changed the title ADM-813[frontend]: add Advance field in metrics page ADM-813[frontend/backend]: add Advance field in metrics page Feb 23, 2024
@sqsq5566
Copy link

暂时不要merge到main分支,需要下周一找fox团队确认需求是否完成再merge

@guzhongren
Copy link
Collaborator

如何处理选择了checkbox,但没有输入值的情况呢?
image

@TingyuDong
Copy link
Author

TingyuDong commented Feb 26, 2024

如何处理选择了checkbox,但没有输入值的情况呢? image

Hi @guzhongren.
选择了checkbox,但没有输入值的情况下:
1.点击save会往config文件里存

 "advancedSettings": {
        "storyPoint": "",
        "flag": ""
    },

2.点击next会往后端传

        overrideFields: [
          {
            name: 'Story Points',
            key: '',
            flag: true,
          },
          {
            name: 'Flagged',
            key: '',
            flag: true,
          },
        ],

@TingyuDong TingyuDong force-pushed the ADM-813 branch 2 times, most recently from 723f3c5 to 8e6633a Compare February 26, 2024 09:51
@TingyuDong
Copy link
Author

如何处理选择了checkbox,但没有输入值的情况呢? image

Hi @guzhongren. 选择了checkbox,但没有输入值的情况下: 1.点击save会往config文件里存

 "advancedSettings": {
        "storyPoint": "",
        "flag": ""
    },

2.点击next会往后端传

        overrideFields: [
          {
            name: 'Story Points',
            key: '',
            flag: true,
          },
          {
            name: 'Flagged',
            key: '',
            flag: true,
          },
        ],

修改后,现在如果没有输入值,存入config文件的为:
"advancedSettings": null,

Copy link

codacy-production bot commented Feb 26, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2522b97) 5639 5639 100.00%
Head commit (f4de003) 11402 (+5763) 11402 (+5763) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1075) 109 109 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@guzhongren
Copy link
Collaborator

  1. 导入的时候怎么处理,有handle么
  2. 对old config 怎么兼容

@TingyuDong
Copy link
Author

TingyuDong commented Feb 27, 2024

  1. 导入的时候怎么处理,有handle么
  2. 对old config 怎么兼容

导入分为三种情况:

  1. 导入包含storyPoint和flag值的config文件,
 "advancedSettings": {
        "storyPoint": "1",
        "flag": "2"
    },

此时Advanced Settings组件展开,页面上展示storyPoint和flag的值。
2. 导入 "advancedSettings": null,的config文件,此时Advanced Settings组件不展开。
3. 导入old config的时候会给advancedSettings设置初始值null。

@TingyuDong TingyuDong merged commit af7a7ea into main Feb 28, 2024
51 checks passed
@TingyuDong TingyuDong deleted the ADM-813 branch February 28, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants