Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] ADM-767: sort the disabled options #1119

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

lxuebing
Copy link

@lxuebing lxuebing commented Mar 6, 2024

Summary

sort the disabled options

Before

Description

Screenshots
image

After

Description

Screenshots
image

Note

Null

Copy link

codacy-production bot commented Mar 6, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (12e6db9) 5749 5749 100.00%
Head commit (b98c8ef) 11502 (+5753) 11502 (+5753) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1119) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link

github-actions bot commented Mar 6, 2024

Hi @lxuebing! 👋
Thank you for submitting a pull request! We appreciate your contribution and will review your changes as soon as possible.

Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed for 'heartbeat-backend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed for 'au-heartbeat-heartbeat-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@lxuebing lxuebing merged commit 8734adf into main Mar 6, 2024
51 checks passed
@lxuebing lxuebing deleted the ADM-767-enhance branch March 6, 2024 06:02
@guzhongren
Copy link
Collaborator

@lxuebing where is there no UT for the sort

lxuebing added a commit that referenced this pull request Mar 7, 2024
* ADM-767 [frontend] feat: sort the disabled options

* ADM-767 [frontend] feat: delete log
lxuebing added a commit that referenced this pull request Mar 7, 2024
* ADM-826 [frontend] style: enhance style for report detail

* AMD-826 [frontend] refactor: abstract boardColor const to theme config

* [frontend] ADM-767: sort the disabled options (#1119)

* ADM-767 [frontend] feat: sort the disabled options

* ADM-767 [frontend] feat: delete log

* fix: put swagger host in the env[backend] (#1120)

* [ADM-826] test: fix e2e test

* [ADM-767] test: add test for sort

---------

Co-authored-by: yp.wu <yiping.wu@yipings-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants