-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADM-886:[docs]docs: update chart API docs content #1326
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
Hi @weiraneve! 👋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没有看懂这个design 前后的不一致, 到时候联系我zoom 一哈
@@ -21,18 +21,16 @@ According to the new business requirements and the roadmap, there are some point | |||
|
|||
- Metrics | |||
|
|||
<img src="https://cdn.jsdelivr.net/gh/au-heartbeat/data-hosting@main/charting-refactor-image/charting-metrics-api.png" width="80%" /> | |||
<img src="https://cdn.jsdelivr.net/gh/au-heartbeat/data-hosting@main/charting-refactor-image/charting-reports-api.png" width="30%" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Draw
sequence diagram
(as code) here, not use the image which was drawed manully - Delete this image in the
data-hosting
repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
今天跟大家讨论了这张卡,后续会有修改,会对docs进行重构和内容改进
Quality Gate passed for 'heartbeat-backend'Issues Measures |
Quality Gate passed for 'au-heartbeat-heartbeat-frontend'Issues Measures |
Summary
...
Before
Description
Screenshots
If applicable, add screenshots to help explain behavior of your code.
After
Description
Screenshots
If applicable, add screenshots to help explain behavior of your code.
Note
Null