Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMD-902 [frontend] feat: pipeline configuration need to retain modified data when user change time range or reverified #1408

Merged
merged 54 commits into from
Apr 23, 2024
Merged

AMD-902 [frontend] feat: pipeline configuration need to retain modified data when user change time range or reverified #1408

merged 54 commits into from
Apr 23, 2024

Conversation

neomgb
Copy link

@neomgb neomgb commented Apr 23, 2024

Summary

pipeline configuration need to retain modified data when user change time range or reverified

Before

Description

Screenshots
If applicable, add screenshots to help explain behavior of your code.

After

Description

Screenshots
If applicable, add screenshots to help explain behavior of your code.

Note

Null

yp.wu and others added 30 commits April 1, 2024 11:26
AMD-902 [frontend] feat: when org and pipeline are same,but step is d…
c093e5b 
…elete,then remove step and branch
AMD-902 [frontend] feat: loading state
b16b5cf
@neomgb
ADM-902: [frontend] fix: fix error message issue
6ed4d8d
AMD-902 [frontend] feat: reset deploymentSettings before load pipelin…
0b46384 
…e info
AMD-902 [frontend] fix: rename matchedStep to filterValidStep
de48138
Merge branch 'main' into ADM-902
3c3dcf5 
# Conflicts:
#	frontend/src/containers/MetricsStep/DeploymentFrequencySettings/BranchSelection/index.tsx
#	frontend/src/containers/MetricsStep/DeploymentFrequencySettings/index.tsx
#	frontend/src/context/meta/metaSlice.tsx
AMD-902 [frontend] fix: fix multiple step fetch
fa9075c
AMD-902 [frontend] fix: remove step and branch when change pipeline name
53d426c
Merge branch 'main' into ADM-902
3fcb93e 
# Conflicts:
#	frontend/src/containers/ConfigStep/DateRangePicker/index.tsx
AMD-902 [frontend] feat: remove init deploymentFrequencySettings
996e9f8
AMD-902 [frontend] fix: should fetch info according shouldLoad value
08c8dbe
AMD-902 [frontend] fix: should fetch info according shouldLoad value
5786c36
@neomgb
ADM-902: [frontend] fix: fix multi piplines are empty
5fe3c55
@neomgb
ADM-902: [frontend] fix: fix multi org are empty
1682fea
Merge branch 'main' into ADM-902
1f4f329 
# Conflicts:
#	frontend/src/containers/ConfigStep/DateRangePicker/DateRangePicker.tsx
AMD-902 [frontend] feat: refactor pipelineCrews structure
14a2831
@neomgb
ADM-902: [frontend] refactor: add empty value process
f9b6ffe
@neomgb
ADM-902: [frontend] feat: add loading process
220a474
AMD-902 [frontend] feat: remove crews in verify response pipelineList
be13b11
@neomgb
ADM-902: [frontend] fix: fix info loading show crews
9f1aabe
@neomgb
ADM-902: [frontend] fix: fix crews render options
8410f47
@neomgb
ADM-902: [frontend] fix: fix multiple pipeline loading issue
02eae01
@neomgb
ADM-902: [frontend] fix: fix unit test
7a20d19
@neomgb
ADM-902: [frontend] fix: fix unit test
91ccfe1
AMD-902 [frontend] fix: fix prettier
95a7b3a
Merge branch 'main' into ADM-902
2f79452 
# Conflicts:
#	frontend/src/containers/ConfigStep/DateRangePicker/DateRangePicker.tsx
#	frontend/src/utils/util.ts
AMD-902 [frontend] test: fix test
c4b5cf7
AMD-902 [frontend] test: add branch for crews when type is other
f7a4979
@neomgb
ADM-902: [frontend] fix: fix unit test
c3f4b8c
AMD-902 [frontend] test: add branch for DeploymentFrequencySettings.t…
4e24b6f 
…est.tsx wehn is firstFetch is true
neomgb and others added 14 commits April 16, 2024 16:58
@codacy-production Codacy Production
Copy link

codacy-production bot commented Apr 23, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.00% ✅ 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5628bea) 6882 6882 100.00%
Head commit (b4503c6) 13866 (+6984) 13866 (+6984) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1408) 87 87 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@github-actions GitHub Actions
Copy link

Hi @neomgb! 👋
Thank you for submitting a pull request! We appreciate your contribution and will review your changes as soon as possible.

TingyuDong
TingyuDong approved these changes Apr 23, 2024
View reviewed changes
Copy link

@TingyuDong TingyuDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Leiqiuhong
Leiqiuhong reviewed Apr 23, 2024
View reviewed changes
Copy link

@Leiqiuhong Leiqiuhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
测试名字修改下；

Leiqiuhong
Leiqiuhong reviewed Apr 23, 2024
View reviewed changes
Copy link

@Leiqiuhong Leiqiuhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'heartbeat-backend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'au-heartbeat-heartbeat-frontend'

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@neomgb neomgb merged commit a1254fb into main Apr 23, 2024
51 checks passed
@neomgb neomgb deleted the ADM-902-new branch April 23, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doujiao-001 doujiao-001 doujiao-001 approved these changes

@Leiqiuhong Leiqiuhong Leiqiuhong approved these changes

@TingyuDong TingyuDong TingyuDong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neomgb @TingyuDong @Leiqiuhong @doujiao-001