Feat/form management config #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bmit validations.
…ntralized `isValid`.
…onger use it to compute the `next` state.
…e it to compute the `next` state.
…bmitSuccessful` instead.
…e for date range.
|
Hi @mrcuriosity-tw! 👋 |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more |
mrcuriosity-tw
requested review from
weiraneve,
PengxiWPix,
TingyuDong,
neomgb and
Leiqiuhong
weiraneve
approved these changes
Apr 25, 2024
… to persist the form submition state while jumping pages.
guzhongren
approved these changes
Apr 25, 2024
|
|
PengxiWPix
pushed a commit
that referenced
this pull request
Apr 28, 2024
* [ADM-887][frontend]: chore: roughly build up the form context. * [ADM-887][frontend]: feat: reconstruct the config step forms. * [ADM-887][frontend]: feat: make <ProjectName /> controlled. * [ADM-887][frontend]: feat: useDefaultValues to make projectName accept imports. * [ADM-887][frontend]: chore: refine code. * [ADM-887][frontend]: feat: integrate <CalendarType /> & <RequiredMetrics />. * [ADM-887][frontend]: feat: integrate <BoardConfig /> form with pre-submit validations. * [ADM-887][frontend]: feat: apply `verify` disabled state with form centralized `isValid`. * [ADM-887][frontend]: feat: refactor the useVerifyBaordEffect * [ADM-887][frontend]: chore: refine code. * [ADM-887][frontend]: feat: integrate <PipelineTool /> with RHF. * [ADM-887][frontend]: feat: integrate <SourceControl /> with RHF. * [ADM-887][frontend]: feat: reset form's validation state when submittion succeeds. * [ADM-887][frontend]: feat: roughly integrate the `next` button state with RHF. * [ADM-887][frontend]: feat: make form re-submit anytime when user change fields. * [ADM-887][frontend]: feat: correct Labels && fix some test. * [ADM-887][frontend]: feat: add <RHFFormProvider /> to facilitate testing. * [ADM-887][frontend]: test: fix <PipelineTool /> test because of aria-label change. * i[ADM-887][frontend]: chore: refine code. * [ADM-887][frontend]: chore: refine code. * [ADM-887][frontend]: feat: refine naming. * [ADM-887][frontend]: test: fix broken test. * [ADM-887][frontend]: test: fix the test of useVerifyBoardEffect. * [ADM-887][frontend]: test: fix the test of useVerifyPipelineToolEffect. * [ADM-887][frontend]: test: refine test. * [ADM-887][frontend]: test: add FormProvider for <BasicInfo /> * [ADM-887][frontend]: feat: remove sourceControl.isVerified since no longer use it to compute the `next` state. * [ADM-887][frontend]: feat: remove board.isVerified since no longer use it to compute the `next` state. * [ADM-887][frontend]: feat: remove `isVerified`, use `isValid` & `isSubmitSuccessful` instead. * [ADM-887][frontend]: feat: complete the schemas of basicInfo except for `dateRange` * [ADM-887][frontend]: feat: manually control the error state when date-range error detected. * [ADM-887][frontend]: feat: integrate the date range with RHF. * [ADM-887][frontend]: feat: persist token in redux when onchange. * [ADM-887][frontend]: feat: persist sourceControl token in redux when onchange. * [ADM-887][frontend]: feat: persist board config in redux when onchange. * [ADM-887][frontend]: feat: customize validation rule for date ranges to synchronise form & UI. * [ADM-887][frontend]: test: fix test. * [ADM-887][frontend]: chore: restore fixture consts. * [ADM-887][frontend]: test: improve testing coverage. * [ADM-887][frontend]: test: improve coverage. * [ADM-887][frontend]: test: cover every scenario to match 100% coverage for date range. * [ADM-887][frontend]: feat: fix lint errors. * [ADM-887][frontend]: feat: no need to give default sort type in useState. * [ADM-887][frontend]: chore: refine code. * [ADM-887][frontend]: feat: move form initialization to MetricsStepper to persist the form submition state while jumping pages. * [ADM-887][frontend]: feat: trigger form validation while adding & removing range. * [ADM-887][frontend]: test: fix ConfigStep test and reduce duplicates of test runner. * [ADM-887][frontend]: chore: abstract CONST for reused labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor config step page to make the page states controled by RHF.
Before
Description
Screenshots
If applicable, add screenshots to help explain behavior of your code.
After
Description
Screenshots
If applicable, add screenshots to help explain behavior of your code.
Note
Null