Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADM-879 [frontend] Generate data reports for multiple time ranges #1425

Merged
merged 33 commits into from
Apr 30, 2024

Conversation

Leiqiuhong
Copy link

Summary

Adm-879 [frontend] Generate data reports for multiple time ranges

Before

Description

Screenshots
If applicable, add screenshots to help explain behavior of your code.

After

Description

Screenshots
If applicable, add screenshots to help explain behavior of your code.

Note

Null

Copy link

codacy-production bot commented Apr 30, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6f99b2c) 7043 7043 100.00%
Head commit (c3a2221) 14300 (+7257) 14300 (+7257) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1425) 193 193 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Copy link

Hi @Leiqiuhong! 👋
Thank you for submitting a pull request! We appreciate your contribution and will review your changes as soon as possible.

@weiraneve weiraneve self-requested a review April 30, 2024 02:15
@PengxiWPix PengxiWPix self-requested a review April 30, 2024 02:17
Copy link

@PengxiWPix PengxiWPix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@TingyuDong TingyuDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@guzhongren guzhongren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change with the comments

frontend/src/hooks/useGenerateReportEffect.ts Outdated Show resolved Hide resolved
frontend/src/hooks/useGenerateReportEffect.ts Outdated Show resolved Hide resolved
frontend/src/hooks/useGenerateReportEffect.ts Outdated Show resolved Hide resolved
frontend/src/hooks/useGenerateReportEffect.ts Outdated Show resolved Hide resolved
frontend/src/hooks/useGenerateReportEffect.ts Outdated Show resolved Hide resolved
@guzhongren
Copy link
Collaborator

fix sonar issues

Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed for 'heartbeat-backend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed for 'au-heartbeat-heartbeat-frontend'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Leiqiuhong Leiqiuhong merged commit d3e5697 into main Apr 30, 2024
61 checks passed
@Leiqiuhong Leiqiuhong deleted the ADM-879-new branch April 30, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants