ADM-928:[frontend]refactor: update code style and add features #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiraneve
requested review from
guzhongren,
mrcuriosity-tw,
PengxiWPix,
TingyuDong,
neomgb and
Leiqiuhong
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more |
|
Hi @weiraneve! 👋 |
Leiqiuhong
reviewed
May 8, 2024
frontend/__tests__/components/Common/DateRangeViewer/DateRangeViewer.test.tsx
Show resolved
Hide resolved
frontend/__tests__/components/Common/DateRangeViewer/DateRangeViewer.test.tsx
Outdated
Show resolved
Hide resolved
Leiqiuhong
reviewed
May 8, 2024
weiraneve
changed the title
guzhongren
approved these changes
May 8, 2024
frontend/__tests__/components/Common/DateRangeViewer/DateRangeViewer.test.tsx
Outdated
Show resolved
Hide resolved
|
|
neomgb
pushed a commit
that referenced
this pull request
May 11, 2024
* ADM-928:[frontend]refactor: update code style * ADM-928:[frontend]refactor: update rejected and fulfilled constants * fix(e2e): rename * fix(e2e): refactor * fix(e2e): format --------- Co-authored-by: guzhongren <guzhongren@live.cn>
neomgb
added a commit
that referenced
this pull request
May 22, 2024
* ADM-880: [frontend] feat: add button style and tab change logic * fix(security): fix security issue * [ADM-931] feat: disable the sort button given invalid date (#1431) * ADM-928:[frontend]feat: add metrics failed date range viewer icon (#1432) * ADM-928:[frontend]feat: add failed time range list * ADM-928:[frontend]feat: add metrics board and pipeline failed time range * ADM-928:[frontend]feat: use priority high icon replace * ADM-928:[frontend]feat: add failed date range icon container style * ADM-928:[frontend]feat: move metrics failed time range logic * ADM-928:[frontend]feat: combine metrics time range logic * ADM-928:[frontend]feat: add update load metrics for update config * ADM-928:[frontend]test: add metrics failed date range viewer icon test * ADM-928:[frontend]feat: update px style * ADM-928:[frontend]refactor: update code conflict * ADM-928:[frontend]test: fix test * ADM-928:[frontend]test: fix jsdom test * ADM-880: [frontend] feat: add data process * ADM-880: [frontend] feat: add data process for board charts * ADM-880: [frontend] feat: modify layout and style * ADM-880: [frontend] feat: modify charts style * ADM-880: [frontend] feat: modify charts style, rename field * ADM-880: [frontend] feat: modify charts style * ADM-880: [frontend] refactor: rename interface * ADM-880: [frontend] feat: modify charts style * ADM-928:[frontend]refactor: update code style and add features (#1433) * ADM-928:[frontend]refactor: update code style * ADM-928:[frontend]refactor: update rejected and fulfilled constants * fix(e2e): rename * fix(e2e): refactor * fix(e2e): format --------- Co-authored-by: guzhongren <guzhongren@live.cn> * Adm-936 [frontend]: When the first pipeline has no steps, it will not crash when adding the pipeline (#1434) * ADM-936 fix: remove the crash logic of pipeline * ADM-936 test: add e2e test * ADM-936 fix: fix eslint * ADM-936 test: add test * ADM-936 test: add unit test * ADM-936 fix: fix e2e test * ADM-940 [frontend][backend]: fix the report file bug (#1437) * ADM-940 [frontend][backend]: fix the bug about deleting expired file * ADM-940 [frontend][backend]: fix the bug about deleting expired file * ADM-940 [frontend][backend]: modify test * ADM-924: [frontend] could export multiple sets of data in report list page (#1436) * ADM-924:[frontend]feat: add download dialog * ADM-924:[backend]feat: display time period * ADM-924:[frontend]feat: add button display logic * ADM-924:[frontend]feat: only show dialog when date range length > 1 * ADM-924:[frontend]feat: display dateRange * ADM-924:[frontend]feat: determine whether a single report can be downloaded by downloadReportList * ADM-924:[frontend]feat: map three sets of list results * ADM-924:[frontend]feat: optimize button disable logic in ReportButtonGroup * ADM-924:[frontend]feat: could select checkbox * ADM-924:[frontend]feat: download csv file in DownloadDialog * ADM-924:[frontend]feat: disable error items * ADM-924:[frontend]feat: add styles to DownloadDialog * ADM-924:[frontend]feat: add toolTip message * ADM-924:[frontend]feat: adjust the tooltip style * ADM-924:[frontend]feat: add background color for checked label * ADM-924:[frontend]feat: remove redundant params in ReportButtonGroup * ADM-924:[frontend]refactor: rename dateRangeItems to dateRangeList * ADM-924:[frontend]refactor: remove unnecessary reportData * ADM-924:[frontend]refactor: export DISABLED_DATE_RANGE_MESSAGE * ADM-924:[frontend]refactor: refactor code * ADM-924:[frontend]refactor: refactor ReportButtonGroup * ADM-924:[frontend]feat: add test * ADM-924:[frontend]feat: the confirm button is un-clickable if user didn’t select any time range * ADM-924:[frontend]feat: enable button only after all the reports completed * ADM-924:[frontend]feat: fetch dataRange data form request result * ADM-924:[frontend]feat: add some css style for DownloadDialog * ADM-924:[frontend]refactor: refactor some code * ADM-924:[frontend]feat: add test for DownloadDialog * ADM-924:[frontend]feat: add test for ReportButtonGroup * ADM-924:[frontend]feat: refactored and supplemented partial tests for ReportButtonGroup * ADM-924:[frontend]feat: added null value checks and refactored code * ADM-924:[frontend]refactor: refactor code & export colors * ADM-924:[frontend]refactor: refactor test for ReportButtonGroup * ADM-924:[frontend]refactor: refactor test & convert color to hex format * ADM-924:[frontend]refactor: align the type of overallMetricsCompleted with boardMetricsCompleted and doraMetricsCompleted in DateRangeRequestResult * ADM-924:[frontend]refactor: refactor exportCSV * ADM-880: [frontend] feat: modify charts style * ADM-880: [frontend] fix: fix numerical accuracy * ADM-880: [frontend] feat: modify charts style * ADM-880: [frontend] feat: modify tabs style * ADM-880: [frontend] feat: modify tabs style * ADM-880: [frontend] feat: modify tabs style * ADM-880: [frontend] feat: add tab logic * ADM-880: [frontend] fix: fix tab logic * ADM-880: [frontend] fix: fix tab logic, modify style * ADM-880: [frontend] feat: fix button change logic * ADM-880: [frontend] fix: fix empty data process * ADM-880: [frontend] fix: fix merge issues * ADM-880:[frontend]fix: refactor stepNumber to enum * ADM-880: [frontend] feat: modify dora charts style * ADM-880:[frontend]fix: fix dateRangeViewer * ADM-880: [frontend] fix: fix unit test * ADM-880: [frontend] test: improve test coverage * ADM-880: [frontend] fix: fix unit test description * ADM-880:[frontend]fix: fix tab indicator style * ADM-880: [frontend] feat: show chart only when date range list is more than one * ADM-880: [frontend] fix: fix unit test * ADM-880: [frontend] refactor: rename field * ADM-880: [frontend] feat: show full year in chart tooltip * ADM-880: [frontend] fix: fix lint * ADM-880: [frontend] test: improve test coverage * ADM-880: [frontend] refactor: extract color constant * ADM-880: [frontend] feat: modify board chart style * ADM-880: [frontend] fix: fix codacy issue * ADM-880: [frontend] fix: fix lint issue * ADM-880: [frontend] fix: fix unit test * ADM-880: [frontend] fix: fix calender date range * ADM-880: [frontend] fix: fix image check * ADM-880: [frontend] fix: use lock file in main branch * ADM-880: [frontend] refactor: refactor hard code to enum * ADM-880: [frontend] feat: add download dialog when click chart tab * ADM-880: [frontend] fix: fix lint error * ADM-924: [frontend] fix: modify tooltip location in download dialog * ADM-924: [frontend] fix: fix lint error * ADM-924: [frontend] refactor: remove hard code * ADM-924: [frontend] fix: fix e2e * ADM-924: [frontend] refactor: add constant * ADM-924: [frontend] fix: fix style issue * ADM-924: [frontend] fix: fix style issue * ADM-924: [frontend] fix: fix lint issue * ADM-924: [frontend] fix: modify style * ADM-924: [frontend] refactor: remove unused optional chain --------- Co-authored-by: guzhongren <guzhongren@live.cn> Co-authored-by: Chao <89126516+mrcuriosity-tw@users.noreply.github.com> Co-authored-by: Steveay <907221539@qq.com> Co-authored-by: Leiqiuhong <141199516+Leiqiuhong@users.noreply.github.com> Co-authored-by: zhou-yinyuan <147299494+zhou-yinyuan@users.noreply.github.com> Co-authored-by: TingyuDong <113588395+TingyuDong@users.noreply.github.com> Co-authored-by: PengxiWPix <pengxi.wang@thoughtworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
...
Before
Description
Screenshots
If applicable, add screenshots to help explain behavior of your code.
After
Description
Screenshots
If applicable, add screenshots to help explain behavior of your code.
Note
Null