Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADM-537:[frontend] Modify error message when no card. #573

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

TingLiMio
Copy link

Summary

  • Modify error message when no card.

Before

Board verify only return done cards.
Crews setting only consider the users who has been assigned to the done cards.
When this is no done card, it will show error message.

Screenshots
Screenshot 2023-08-04 at 11 30 55 (2)

After

Board verify only return done cards.
Crews setting include the all users who has been assigned to one card.
When this is no card, it will show error message.

Screenshots
Screenshot 2023-08-04 at 11 32 34 (2)

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Hi @TingLiMio! 👋
Thank you for submitting a pull request! We appreciate your contribution and will review your changes as soon as possible.

@codacy-production
Copy link

codacy-production bot commented Aug 4, 2023

Coverage summary from Codacy

Merging #573 (e1be16b) into main (fcc3fa7) - See PR on Codacy

Coverage variation Diff coverage
+0.00% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (fcc3fa7) 3858 3858 100.00%
Head commit (e1be16b) 3859 (+1) 3859 (+1) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#573) 4 4 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@TingLiMio TingLiMio merged commit cbc7f95 into main Aug 4, 2023
@TingLiMio TingLiMio deleted the ADM-537 branch August 4, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants