Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adm-649:[Backend][Frontend] Verify failed when return GitHub repos size empty #789

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

weiraneve
Copy link

Summary

fronted:
When the Source Control input receives Github tokens and is verified, the button should update to 'Verify' instead of 'Reset'. This logic is synchronized with the Board and Pipeline Tool.

backend:
After inputting Github tokens, if the server verifies the token and returns an empty Github repositories result, then an exception should be thrown.

Before

Description

Screenshots
brefore

After

Description

Screenshots
after

Note

Null

Copy link

github-actions bot commented Dec 5, 2023

Hi @weiraneve! 👋
Thank you for submitting a pull request! We appreciate your contribution and will review your changes as soon as possible.

Copy link

codacy-production bot commented Dec 5, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3c41386) 4272 4272 100.00%
Head commit (6802847) 4272 (+0) 4272 (+0) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#789) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@weiraneve weiraneve merged commit 8e47b78 into main Dec 6, 2023
36 checks passed
@weiraneve weiraneve deleted the ADM-649 branch December 6, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants