Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADM-747: [frontend] feat: handle error #968

Merged
merged 14 commits into from
Jan 22, 2024
Merged

ADM-747: [frontend] feat: handle error #968

merged 14 commits into from
Jan 22, 2024

Conversation

JiangRu1
Copy link

Summary

...

Before

Description

Screenshots
If applicable, add screenshots to help explain behavior of your code.

After

Description

Screenshots
If applicable, add screenshots to help explain behavior of your code.

Note

Null

Copy link

Hi @JiangRu1! 👋
Thank you for submitting a pull request! We appreciate your contribution and will review your changes as soon as possible.

Copy link

codacy-production bot commented Jan 22, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6512481) 5422 5422 100.00%
Head commit (9be1343) 10870 (+5448) 10870 (+5448) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#968) 76 76 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@JiangRu1 JiangRu1 merged commit c629952 into main Jan 22, 2024
49 checks passed
@JiangRu1 JiangRu1 deleted the ADM-747 branch January 22, 2024 07:32
K-Chow pushed a commit that referenced this pull request Jan 22, 2024
* ADM-747: [frontend] refactor: refactor notification

* ADM-747: [frontend] refactor: set default title for notification

* ADM-747: [frontend] feat: handle timeout error

* ADM-747: [frontend] feat: handle report error

* ADM-747: [frontend] refactor: rename reportMetricsError

* ADM-747: [frontend] refactor: replace enum with object

* ADM-747: [frontend] feat: handle report error

* ADM-747: [frontend] feat: handle export error

* ADM-747: [frontend] test: add tests for error notifications

* ADM-747: [frontend] refactor: refactor report useEffect

* ADM-747: [frontend] refactor: refactor TimeoutException

* ADM-747: [frontend] refactor: delete useless isServerError

* ADM-747: [frontend] test: add e2e tests for date picker

* ADM-747: [frontend] fix: fix import
PengxiWPix pushed a commit that referenced this pull request Jan 24, 2024
* ADM-747: [frontend] refactor: refactor notification

* ADM-747: [frontend] refactor: set default title for notification

* ADM-747: [frontend] feat: handle timeout error

* ADM-747: [frontend] feat: handle report error

* ADM-747: [frontend] refactor: rename reportMetricsError

* ADM-747: [frontend] refactor: replace enum with object

* ADM-747: [frontend] feat: handle report error

* ADM-747: [frontend] feat: handle export error

* ADM-747: [frontend] test: add tests for error notifications

* ADM-747: [frontend] refactor: refactor report useEffect

* ADM-747: [frontend] refactor: refactor TimeoutException

* ADM-747: [frontend] refactor: delete useless isServerError

* ADM-747: [frontend] test: add e2e tests for date picker

* ADM-747: [frontend] fix: fix import
K-Chow pushed a commit that referenced this pull request Jan 24, 2024
* ADM-747: [frontend] refactor: refactor notification

* ADM-747: [frontend] refactor: set default title for notification

* ADM-747: [frontend] feat: handle timeout error

* ADM-747: [frontend] feat: handle report error

* ADM-747: [frontend] refactor: rename reportMetricsError

* ADM-747: [frontend] refactor: replace enum with object

* ADM-747: [frontend] feat: handle report error

* ADM-747: [frontend] feat: handle export error

* ADM-747: [frontend] test: add tests for error notifications

* ADM-747: [frontend] refactor: refactor report useEffect

* ADM-747: [frontend] refactor: refactor TimeoutException

* ADM-747: [frontend] refactor: delete useless isServerError

* ADM-747: [frontend] test: add e2e tests for date picker

* ADM-747: [frontend] fix: fix import
K-Chow pushed a commit that referenced this pull request Jan 24, 2024
* ADM-747: [frontend] refactor: refactor notification

* ADM-747: [frontend] refactor: set default title for notification

* ADM-747: [frontend] feat: handle timeout error

* ADM-747: [frontend] feat: handle report error

* ADM-747: [frontend] refactor: rename reportMetricsError

* ADM-747: [frontend] refactor: replace enum with object

* ADM-747: [frontend] feat: handle report error

* ADM-747: [frontend] feat: handle export error

* ADM-747: [frontend] test: add tests for error notifications

* ADM-747: [frontend] refactor: refactor report useEffect

* ADM-747: [frontend] refactor: refactor TimeoutException

* ADM-747: [frontend] refactor: delete useless isServerError

* ADM-747: [frontend] test: add e2e tests for date picker

* ADM-747: [frontend] fix: fix import
K-Chow pushed a commit that referenced this pull request Jan 24, 2024
* ADM-747: [frontend] refactor: refactor notification

* ADM-747: [frontend] refactor: set default title for notification

* ADM-747: [frontend] feat: handle timeout error

* ADM-747: [frontend] feat: handle report error

* ADM-747: [frontend] refactor: rename reportMetricsError

* ADM-747: [frontend] refactor: replace enum with object

* ADM-747: [frontend] feat: handle report error

* ADM-747: [frontend] feat: handle export error

* ADM-747: [frontend] test: add tests for error notifications

* ADM-747: [frontend] refactor: refactor report useEffect

* ADM-747: [frontend] refactor: refactor TimeoutException

* ADM-747: [frontend] refactor: delete useless isServerError

* ADM-747: [frontend] test: add e2e tests for date picker

* ADM-747: [frontend] fix: fix import
SimonTal pushed a commit that referenced this pull request Jan 30, 2024
* ADM-747: [frontend] refactor: refactor notification

* ADM-747: [frontend] refactor: set default title for notification

* ADM-747: [frontend] feat: handle timeout error

* ADM-747: [frontend] feat: handle report error

* ADM-747: [frontend] refactor: rename reportMetricsError

* ADM-747: [frontend] refactor: replace enum with object

* ADM-747: [frontend] feat: handle report error

* ADM-747: [frontend] feat: handle export error

* ADM-747: [frontend] test: add tests for error notifications

* ADM-747: [frontend] refactor: refactor report useEffect

* ADM-747: [frontend] refactor: refactor TimeoutException

* ADM-747: [frontend] refactor: delete useless isServerError

* ADM-747: [frontend] test: add e2e tests for date picker

* ADM-747: [frontend] fix: fix import
SimonTal pushed a commit that referenced this pull request Jan 30, 2024
* ADM-747: [frontend] refactor: refactor notification

* ADM-747: [frontend] refactor: set default title for notification

* ADM-747: [frontend] feat: handle timeout error

* ADM-747: [frontend] feat: handle report error

* ADM-747: [frontend] refactor: rename reportMetricsError

* ADM-747: [frontend] refactor: replace enum with object

* ADM-747: [frontend] feat: handle report error

* ADM-747: [frontend] feat: handle export error

* ADM-747: [frontend] test: add tests for error notifications

* ADM-747: [frontend] refactor: refactor report useEffect

* ADM-747: [frontend] refactor: refactor TimeoutException

* ADM-747: [frontend] refactor: delete useless isServerError

* ADM-747: [frontend] test: add e2e tests for date picker

* ADM-747: [frontend] fix: fix import
SimonTal added a commit that referenced this pull request Feb 1, 2024
…985)

* [kai.zhou][adm-718] feat: remove project key field

* [kai.zhou][adm-718]: feat: add addtional key for form field

* [kai.zhou][adm-718] fix unit test

* [kai.zhou][adm-718]: fix: ignore no coverage function

* [kai.zhou][adm-718]: feat: start integrate info api

* [kai.zhou][adm-718]: fix: fix code typo

* [kai.zhou][adm-718]: feat: update error handle for verify api

* [kai.zhou][adm-718]: feat: refact valid rule

* [kai.zhou][adm-718]: update get info callback

* [kai.zhou][adm-718]: refact board info call in metric page

* [kai.zhou][adm-718]: create new empty content component

* [kai.zhou][adm-718]: test: fix some unit test

* ADM-747: [frontend] feat: handle error (#968)

* ADM-747: [frontend] refactor: refactor notification

* ADM-747: [frontend] refactor: set default title for notification

* ADM-747: [frontend] feat: handle timeout error

* ADM-747: [frontend] feat: handle report error

* ADM-747: [frontend] refactor: rename reportMetricsError

* ADM-747: [frontend] refactor: replace enum with object

* ADM-747: [frontend] feat: handle report error

* ADM-747: [frontend] feat: handle export error

* ADM-747: [frontend] test: add tests for error notifications

* ADM-747: [frontend] refactor: refactor report useEffect

* ADM-747: [frontend] refactor: refactor TimeoutException

* ADM-747: [frontend] refactor: delete useless isServerError

* ADM-747: [frontend] test: add e2e tests for date picker

* ADM-747: [frontend] fix: fix import

* [kai.zhou][adm-718]: refact board info call in metric page

* [kai.zhou][adm-718]: create new empty content component

* [kai.zhou][adm-718]: test: fix some unit test

* [kai.zhou][adm-718]: chroe: format code

* [kai.zhou][adm-718]: refact board info call in metric page

* [kai.zhou][adm-718]: create new empty content component

* [kai.zhou][adm-718]: test: fix some unit test

* [kai.zhou][adm-718]: refact board info call in metric page

* [kai.zhou][adm-718]: test: fix some unit test

* [kai.zhou][adm-718]: chroe: format code

* [kai.zhou][adm-718]: fix failed unit test

* [kai.zhou][adm-718]: add new  stub for jira verify

* [kai.zhou][adm-718]: fix failed unit test

* [kai.zhou][adm-718]: add unit test for useVerifyBoardEffect

* [kai.zhou][adm-718]: fix unit test coverage

* [kai.zhou][adm-718]: update e2e test

* [kai.zhou][adm-718]: update e2e stub

* [kai.zhou][adm-718]: update stub data

* ADM-718:[Frontend] Fix E2E stub data

* ADM-718:[Frontend] Fix E2E stub data

* ADM-718:[Frontend] Fix E2E stub data

* [kai.zhou][adm-718]: fix email fields not post and ignore some e2e script

* [kai.zhou][adm-718]: refact board info call in metric page

* [kai.zhou][adm-718]: create new empty content component

* [kai.zhou][adm-718]: test: fix some unit test

* ADM-747: [frontend] feat: handle error (#968)

* ADM-747: [frontend] refactor: refactor notification

* ADM-747: [frontend] refactor: set default title for notification

* ADM-747: [frontend] feat: handle timeout error

* ADM-747: [frontend] feat: handle report error

* ADM-747: [frontend] refactor: rename reportMetricsError

* ADM-747: [frontend] refactor: replace enum with object

* ADM-747: [frontend] feat: handle report error

* ADM-747: [frontend] feat: handle export error

* ADM-747: [frontend] test: add tests for error notifications

* ADM-747: [frontend] refactor: refactor report useEffect

* ADM-747: [frontend] refactor: refactor TimeoutException

* ADM-747: [frontend] refactor: delete useless isServerError

* ADM-747: [frontend] test: add e2e tests for date picker

* ADM-747: [frontend] fix: fix import

* [kai.zhou][adm-718]: refact board info call in metric page

* [kai.zhou][adm-718]: test: fix some unit test

* [kai.zhou][adm-718]: chroe: format code

* [ADM-740] show not show real done when cycle time by status (#972)

Co-authored-by: wenjing-qi <wenjing.qi@rea-group.com>

* [kai.zhou][adm-718]: refact board info call in metric page

* [kai.zhou][adm-718]: create new empty content component

* [kai.zhou][adm-718]: test: fix some unit test

* [kai.zhou][adm-718]: refact board info call in metric page

* [kai.zhou][adm-718]: test: fix some unit test

* [kai.zhou][adm-718]: chroe: format code

* [kai.zhou][adm-718]: fix failed unit test

* [kai.zhou][adm-718]: fix unit test coverage

* [kai.zhou][adm-718]: fix typo

* [kai.zhou][adm-718]: fix local conflict

* [kai.zhou][adm-718]: fix failed test

* [kai.zhou][adm-718]: fix type

* [kai.zhou][adm-718]: fix code for review

* [kai.zhou][adm-718]: fix test typo

* [kai.zhou][adm-718]: fix code styles

* [kai.zhou][adm-718]: fix failed test

* [kai.zhou][adm-718]: refact email token mix

* [kai.zhou][adm-718]: add new test case

* [kai.zhou][adm-718]: fix code styles

* [kai.zhou][adm-718]: skip e2e test for creat project

* [kai.zhou][adm-718]: fix pr issue

* [kai.zhou][adm-718]: fix codacy issue

* [kai.zhou][adm-718]: fix codacy issue

* [kai.zhou][adm-718]: fix codacy issue

* [kai.zhou][adm-718]: fix codacy issue

* [kai.zhou][adm-718]: fix failed test

* [kai.zhou][adm-718]: refact unit test

* ADM-718:[Frontend] Fix Codacy issue

* ADM-718:[Frontend] Fix rebase issue

* ADM-718:[Frontend] Fix test case

* [kai.zhou][adm-718]: fix not show form error

* [kai.zhou][adm-718]: fix issues about deskcheck

* ADM-718:[Frontend] Fix unit test case

* [kai.zhou]: support reset error message when change form field

* [kai.zhou][adm-718]: fix failed test

* [kai.zhou][adm-718]: fix Classification can not update

* [kai.zhou][adm-718]: refact unit test for classification

* [kai.zhou][adm-718]: fix failed lint

* [kai.zhou][adm-718]: fix lint warning

* ADM-718:[Frontend] Remove some comments for E2E tests

* [kai.zhou][adm-718]: fix form field warning

---------

Co-authored-by: 姜如 <77052266+JiangRu1@users.noreply.github.com>
Co-authored-by: Simon Tal <simon_tal@hotmail.com>
Co-authored-by: gabralia <gabralia@qq.com>
Co-authored-by: wenjing-qi <wenjing.qi@rea-group.com>
mikeyangyun pushed a commit that referenced this pull request Feb 1, 2024
…985)

* [kai.zhou][adm-718] feat: remove project key field

* [kai.zhou][adm-718]: feat: add addtional key for form field

* [kai.zhou][adm-718] fix unit test

* [kai.zhou][adm-718]: fix: ignore no coverage function

* [kai.zhou][adm-718]: feat: start integrate info api

* [kai.zhou][adm-718]: fix: fix code typo

* [kai.zhou][adm-718]: feat: update error handle for verify api

* [kai.zhou][adm-718]: feat: refact valid rule

* [kai.zhou][adm-718]: update get info callback

* [kai.zhou][adm-718]: refact board info call in metric page

* [kai.zhou][adm-718]: create new empty content component

* [kai.zhou][adm-718]: test: fix some unit test

* ADM-747: [frontend] feat: handle error (#968)

* ADM-747: [frontend] refactor: refactor notification

* ADM-747: [frontend] refactor: set default title for notification

* ADM-747: [frontend] feat: handle timeout error

* ADM-747: [frontend] feat: handle report error

* ADM-747: [frontend] refactor: rename reportMetricsError

* ADM-747: [frontend] refactor: replace enum with object

* ADM-747: [frontend] feat: handle report error

* ADM-747: [frontend] feat: handle export error

* ADM-747: [frontend] test: add tests for error notifications

* ADM-747: [frontend] refactor: refactor report useEffect

* ADM-747: [frontend] refactor: refactor TimeoutException

* ADM-747: [frontend] refactor: delete useless isServerError

* ADM-747: [frontend] test: add e2e tests for date picker

* ADM-747: [frontend] fix: fix import

* [kai.zhou][adm-718]: refact board info call in metric page

* [kai.zhou][adm-718]: create new empty content component

* [kai.zhou][adm-718]: test: fix some unit test

* [kai.zhou][adm-718]: chroe: format code

* [kai.zhou][adm-718]: refact board info call in metric page

* [kai.zhou][adm-718]: create new empty content component

* [kai.zhou][adm-718]: test: fix some unit test

* [kai.zhou][adm-718]: refact board info call in metric page

* [kai.zhou][adm-718]: test: fix some unit test

* [kai.zhou][adm-718]: chroe: format code

* [kai.zhou][adm-718]: fix failed unit test

* [kai.zhou][adm-718]: add new  stub for jira verify

* [kai.zhou][adm-718]: fix failed unit test

* [kai.zhou][adm-718]: add unit test for useVerifyBoardEffect

* [kai.zhou][adm-718]: fix unit test coverage

* [kai.zhou][adm-718]: update e2e test

* [kai.zhou][adm-718]: update e2e stub

* [kai.zhou][adm-718]: update stub data

* ADM-718:[Frontend] Fix E2E stub data

* ADM-718:[Frontend] Fix E2E stub data

* ADM-718:[Frontend] Fix E2E stub data

* [kai.zhou][adm-718]: fix email fields not post and ignore some e2e script

* [kai.zhou][adm-718]: refact board info call in metric page

* [kai.zhou][adm-718]: create new empty content component

* [kai.zhou][adm-718]: test: fix some unit test

* ADM-747: [frontend] feat: handle error (#968)

* ADM-747: [frontend] refactor: refactor notification

* ADM-747: [frontend] refactor: set default title for notification

* ADM-747: [frontend] feat: handle timeout error

* ADM-747: [frontend] feat: handle report error

* ADM-747: [frontend] refactor: rename reportMetricsError

* ADM-747: [frontend] refactor: replace enum with object

* ADM-747: [frontend] feat: handle report error

* ADM-747: [frontend] feat: handle export error

* ADM-747: [frontend] test: add tests for error notifications

* ADM-747: [frontend] refactor: refactor report useEffect

* ADM-747: [frontend] refactor: refactor TimeoutException

* ADM-747: [frontend] refactor: delete useless isServerError

* ADM-747: [frontend] test: add e2e tests for date picker

* ADM-747: [frontend] fix: fix import

* [kai.zhou][adm-718]: refact board info call in metric page

* [kai.zhou][adm-718]: test: fix some unit test

* [kai.zhou][adm-718]: chroe: format code

* [ADM-740] show not show real done when cycle time by status (#972)

Co-authored-by: wenjing-qi <wenjing.qi@rea-group.com>

* [kai.zhou][adm-718]: refact board info call in metric page

* [kai.zhou][adm-718]: create new empty content component

* [kai.zhou][adm-718]: test: fix some unit test

* [kai.zhou][adm-718]: refact board info call in metric page

* [kai.zhou][adm-718]: test: fix some unit test

* [kai.zhou][adm-718]: chroe: format code

* [kai.zhou][adm-718]: fix failed unit test

* [kai.zhou][adm-718]: fix unit test coverage

* [kai.zhou][adm-718]: fix typo

* [kai.zhou][adm-718]: fix local conflict

* [kai.zhou][adm-718]: fix failed test

* [kai.zhou][adm-718]: fix type

* [kai.zhou][adm-718]: fix code for review

* [kai.zhou][adm-718]: fix test typo

* [kai.zhou][adm-718]: fix code styles

* [kai.zhou][adm-718]: fix failed test

* [kai.zhou][adm-718]: refact email token mix

* [kai.zhou][adm-718]: add new test case

* [kai.zhou][adm-718]: fix code styles

* [kai.zhou][adm-718]: skip e2e test for creat project

* [kai.zhou][adm-718]: fix pr issue

* [kai.zhou][adm-718]: fix codacy issue

* [kai.zhou][adm-718]: fix codacy issue

* [kai.zhou][adm-718]: fix codacy issue

* [kai.zhou][adm-718]: fix codacy issue

* [kai.zhou][adm-718]: fix failed test

* [kai.zhou][adm-718]: refact unit test

* ADM-718:[Frontend] Fix Codacy issue

* ADM-718:[Frontend] Fix rebase issue

* ADM-718:[Frontend] Fix test case

* [kai.zhou][adm-718]: fix not show form error

* [kai.zhou][adm-718]: fix issues about deskcheck

* ADM-718:[Frontend] Fix unit test case

* [kai.zhou]: support reset error message when change form field

* [kai.zhou][adm-718]: fix failed test

* [kai.zhou][adm-718]: fix Classification can not update

* [kai.zhou][adm-718]: refact unit test for classification

* [kai.zhou][adm-718]: fix failed lint

* [kai.zhou][adm-718]: fix lint warning

* ADM-718:[Frontend] Remove some comments for E2E tests

* [kai.zhou][adm-718]: fix form field warning

---------

Co-authored-by: 姜如 <77052266+JiangRu1@users.noreply.github.com>
Co-authored-by: Simon Tal <simon_tal@hotmail.com>
Co-authored-by: gabralia <gabralia@qq.com>
Co-authored-by: wenjing-qi <wenjing.qi@rea-group.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants