Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attribute support #5

Closed
au5ton opened this issue Jun 25, 2021 · 4 comments
Closed

attribute support #5

au5ton opened this issue Jun 25, 2021 · 4 comments

Comments

@au5ton
Copy link
Owner

au5ton commented Jun 25, 2021

No description provided.

@au5ton
Copy link
Owner Author

au5ton commented Jul 1, 2021

  • input placeholders
  • (maybe) input[type=submit] values
  • the "title" attribute on vanilla HTML elements

@au5ton
Copy link
Owner Author

au5ton commented Jul 20, 2021

potential follow-up: support certain ARIA attributes?

au5ton added a commit that referenced this issue Jul 20, 2021
@au5ton
Copy link
Owner Author

au5ton commented Jul 20, 2021

input[type=submit] can't have its value attribute translated, however, button[type=submit] can have it's nodeValue translated if it has a coded value attribute

it is recommended that site owners who wish to translate submit buttons switch:

  • From:
    <input type="submit" value="foo" />
  • To:
    <button type="submit" value="foo">This is translatable</button>

In the current codebase, after making the switch, translation will be performed.

@au5ton
Copy link
Owner Author

au5ton commented Jul 20, 2021

"attribute" selectors

  • *[title]
  • input[placeholder]
  • img[alt]

@au5ton au5ton closed this as completed in f8f3877 Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant