Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add connectors #51

Merged
merged 1 commit into from
Mar 14, 2022
Merged

feat: add connectors #51

merged 1 commit into from
Mar 14, 2022

Conversation

tarrencev
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2022

🦋 Changeset detected

Latest commit: 9198db0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@starknet-react/core Minor
starknet-react-next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fracek
Copy link
Contributor

fracek commented Mar 13, 2022

This PR looks very good. I think the only thing left to do is update the website to use the new API.

  • website/src/components/Demo.tsx
  • website/docs/intro.md
  • website/docs/hooks/starknet.md

@fracek
Copy link
Contributor

fracek commented Mar 13, 2022

Looks like the build is failing because the compiler used by nextjs doesn't like circular dependencies. Can you move the Connector interface to src/connectors/connector.ts and then adjust the imports?

@fracek fracek merged commit 8171dae into apibara:main Mar 14, 2022
@github-actions github-actions bot mentioned this pull request Mar 14, 2022
@tarrencev tarrencev deleted the feat/connectors branch March 14, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants