Add follow_symlink argument to rmdir() #141
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
follow_symlink
argument toaudeer.rmdir()
, but sets it toTrue
as default as this is avoids breaking changes and seems to be a meaningful behavior.I decided against silently setting it to
True
internally as we still useaudeer.rmdir()
in loops that can get a speed up by ensuring that we don't have a symbolic link before we callaudeer.rmdir()
, e.g. https://github.com/audeering/audb/blob/12ad8520e45c11f152c5c96b11f221e3a1fb40f2/audb/core/load_to.py#L303-L329I also added tests and included a new error under Raises section in the docstring that can happen with
follow_symlink=False
.