Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use different artifacts names in publish.yml #119

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Dec 16, 2024

In #113 we updated the actions used to upload and download Artifacts in the publish.yml workflow. This leads to an error when trying to publish as the artifacts need to have different names now.

This is fixed in this pull request by using the platform for which the artifact is built for as name.

Summary by Sourcery

CI:

  • Update artifact naming in publish.yml to use platform-specific names, resolving publishing errors.

Copy link
Contributor

sourcery-ai bot commented Dec 16, 2024

Reviewer's Guide by Sourcery

The pull request modifies the GitHub Actions workflow to fix an artifact naming issue in the CI/CD pipeline. The change adds a unique name to the upload-artifact action by using the platform matrix variable as the artifact name, which prevents naming conflicts during the publishing process.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated artifact naming in GitHub Actions workflow
  • Added platform-specific naming for uploaded artifacts using matrix.platform variable
  • Ensures unique artifact names for different build platforms
.github/workflows/publish.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hagenw - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@hagenw hagenw merged commit 58f9bc8 into main Dec 16, 2024
17 checks passed
@hagenw hagenw deleted the ci-fix-publish branch December 16, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant