Skip to content
This repository has been archived by the owner on May 29, 2020. It is now read-only.

Deleting plugin doesn't remove auto-update preference #29

Closed
bookdude13 opened this issue Mar 2, 2020 · 5 comments · Fixed by #32
Closed

Deleting plugin doesn't remove auto-update preference #29

bookdude13 opened this issue Mar 2, 2020 · 5 comments · Fixed by #32
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@bookdude13
Copy link
Contributor

Not sure if this is good or bad. Auto-update is set to enabled on second install. Reproduction steps:

  • Install plugin (I did from file; untested with other means)
  • Enable auto-updates
  • Remove it using Delete link in left column
  • At this point you can refresh, log out, or do nothing - it doesn't matter
  • Install the plugin again (again, I did from file. Different versions still had this bug happen)
  • Note that auto-updates are enabled
@pbiron
Copy link
Collaborator

pbiron commented Mar 2, 2020

I've noticed this in my testing as well.

I think that we can hook into the deleted_plugin action and remove the deleted plugin from the wp_auto_update_plugins site option. I'll do a PR for that when I get a chance (unless someone beats me to it :-).

@bookdude13
Copy link
Contributor Author

I'll take a swing at it tonight :)

@pbiron
Copy link
Collaborator

pbiron commented Mar 2, 2020

I'll take a swing at it tonight :)

he took the hint :-) Thanx!

@bookdude13
Copy link
Contributor Author

Thanks for the outline of what to do; that was my first time dealing directly with hooks in plugins, and it was a great way to get exposed!

@audrasjb
Copy link
Owner

audrasjb commented Mar 3, 2020

Yeah this should be fixed. Milestoning for 0.2

@audrasjb audrasjb added this to the 0.2.0 milestone Mar 3, 2020
@audrasjb audrasjb self-assigned this Mar 3, 2020
@audrasjb audrasjb added the enhancement New feature or request label Mar 3, 2020
pedro-mendonca pushed a commit to pedro-mendonca/wp-autoupdates that referenced this issue Apr 4, 2020
Remove features / to-do list from readme.md

Thanks for pointing this @jeffpaul 👍
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants