Add test data for Recipes to H2LP #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM on first glance. Still need to double check the test data. |
|
@pujak17 Missing for this PR is stripping most content from the new HTML test files as we do not want to store the full HTML content inside our repository. |
pujak17
changed the title
jaudriga
reviewed
May 28, 2024
pujak17
force-pushed
the
3-improving-test-data
branch
2 times, most recently
from
1f686ff
to
d50c034
Compare
pujak17
force-pushed
the
3-improving-test-data
branch
from
e59a5d3
to
184b58b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR will add 3 new HTML files retrieved from:
nextcloud/cookbook#1592
nextcloud/cookbook#1509
nextcloud/cookbook#1508
and corresponding tests to
tests/unit/MarkupUtilTest.phpTest Status:
phpunit:successReferences:
#3