print warning when ignoring unknown luminance formula

auerswal · Nov 18, 2024 · 88a6270 · 88a6270
1 parent 6e8c836
commit 88a6270
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/NEWS b/NEWS
@@ -4,6 +4,7 @@ Noteworthy Changes in ssocr Releases
 Version X.XX.X (XXXX-XX-XX):
 ----------------------------
  * Print warning when an unknown charset name is ignored
+ * Print warning when an unknown luminance formula name is ignored
  * Fix one debug message to be printed only with -P, --debug-output
  * Documentation improvements
 

diff --git a/defines.h b/defines.h
@@ -187,7 +187,8 @@ typedef enum luminance_e {
   MAXIMUM,
   RED,
   GREEN,
-  BLUE
+  BLUE,
+  LUM_PARSE_ERROR
 } luminance_t;
 
 /* direction, to mirror horizontally or vertically, or for a scanline */

diff --git a/imgproc.c b/imgproc.c
@@ -1126,7 +1126,7 @@ luminance_t parse_lum(char *keyword)
   } else if(strcasecmp(keyword, "blue") == 0) {
     return BLUE;
   } else {
-    return DEFAULT_LUM_FORMULA;
+    return LUM_PARSE_ERROR;
   }
 }
 

diff --git a/ssocr.c b/ssocr.c
@@ -532,6 +532,12 @@ int main(int argc, char **argv)
       case 'l':
         if(optarg) {
           lt = parse_lum(optarg);
+          if(lt == LUM_PARSE_ERROR) {
+            fprintf(stderr,
+                    PROG ": warning: ignoring unknown luminance formula '%s'\n",
+                    optarg);
+            lt = DEFAULT_LUM_FORMULA;
+          }
         }
         break;
       case 'S':