Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration between Board Generation and Minigames #23

Open
wants to merge 95 commits into
base: tiles
Choose a base branch
from

Conversation

erwang01
Copy link
Contributor

@erwang01 erwang01 commented May 5, 2020

No description provided.

sanathsengupta and others added 30 commits February 27, 2020 00:21
…rk on displaying board outline based on camera orientation
@erwang01
Copy link
Contributor Author

erwang01 commented Jun 7, 2020

Shall we begin merging everything into master?

I think everything is "working" at this point. TraceGame crashes occasionally but I haven't been able to reliably reproduce it... #25

Definitely still have some work to do with the background #26 and the tile coloring when the background is active #27 but perhaps we can roll this out once content / storyline is decided.

Copy link
Contributor Author

@erwang01 erwang01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partial review.

import UIKit

/*
Defines the visual attributes of the 'Generate Board' button to be added to the view during board generation
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swift Documentation.

import UIKit

/*
Defines the visual attributes of the 'Rotate Board' button to be added to the view during board generation
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swift Documentation

}
}

func isCorner(coord: Tile.Coordinates) -> Bool{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Swift Documentation.

class Minigame : Entity {

/// Score / completion status of the minigame in the range [0.0, 100.0]
@Published var score : Float
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a better definition for score.

return view
}()

private lazy var progressView: MultiProgressView = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add documentation.

import ARKit
import RealityKit

/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turn into swift mkdwn

})
}

func startMinigame(gameType: Game) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document


// MARK: Switching between Board and Minigame
extension ViewController {
func addCollision() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document

controller.didMove(toParent: self)
}

func setupMinigames(ground: AnchorEntity) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document


/// AR View
@IBOutlet var arView: ARView!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants