Merge pull request #3435 from aura-nw/fix/sere/crash-share-comp

fix: crash app when reading undefined var
aura-nw · May 28, 2024 · 0496185 · 0496185
2 parents 79d54af + 68e479d
commit 0496185
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/src/app/core/utils/common/address-converter.ts b/src/app/core/utils/common/address-converter.ts
@@ -102,7 +102,7 @@ export function transferAddress(prefix: string, address: string) {
  };
  }
 
- if (address.startsWith(EWalletType.EVM)) {
+ if (address?.startsWith(EWalletType.EVM)) {
  return {
  accountEvmAddress: address?.toLowerCase(),
  accountAddress: convertEvmAddressToBech32Address(prefix, address),
@@ -122,3 +122,4 @@ export function getEvmChecksumAddress(address: string) {
  return address;
  }
 }
+
diff --git a/src/app/pages/evm-token/evm-nft-detail/evm-popup-share/evm-popup-share.component.ts b/src/app/pages/evm-token/evm-nft-detail/evm-popup-share/evm-popup-share.component.ts
@@ -32,8 +32,8 @@ export class EvmPopupShareComponent implements OnInit {
  '';
  }
 
- closeDialog(isConfirm = false) {
- this.dialogRef.close(isConfirm);
+ closeDialog() {
+ this.dialogRef.close(true);
  }
 
  executeShareLink(mode) {
@@ -73,3 +73,4 @@ export class EvmPopupShareComponent implements OnInit {
  document.getElementById(item).classList.remove('icon--multi-color');
  }
 }
+
diff --git a/src/app/pages/token-cosmos/nft-detail/popup-share/popup-share.component.ts b/src/app/pages/token-cosmos/nft-detail/popup-share/popup-share.component.ts
@@ -32,8 +32,8 @@ export class PopupShareComponent implements OnInit {
  '';
  }
 
- closeDialog(isConfirm = false) {
- this.dialogRef.close(isConfirm);
+ closeDialog() {
+ this.dialogRef.close(true);
  }
 
  executeShareLink(mode) {
@@ -73,3 +73,4 @@ export class PopupShareComponent implements OnInit {
  document.getElementById(item).classList.remove('icon--multi-color');
  }
 }
+