-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove numberOfBlockPerCall to use blocksPerCall in crawl block, tx #708
fix: remove numberOfBlockPerCall to use blocksPerCall in crawl block, tx #708
Conversation
WalkthroughThe recent updates involve configuration and service modifications in a codebase, primarily focusing on renaming a key for clarity, introducing a new key, and adjusting service logic to align with these configuration changes. The essence of these updates is to streamline the process of crawling blocks and transactions by enhancing parameter naming, adding necessary configurations, and ensuring service components use these updated configurations correctly. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (4)
Additional comments not posted (6)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
666073c
to
6c9c79f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
config.json
is excluded by:!**/*.json
Files selected for processing (3)
- ci/config.json.ci (1 hunks)
- src/services/crawl-block/crawl_block.service.ts (1 hunks)
- src/services/crawl-tx/crawl_tx.service.ts (1 hunks)
Additional comments: 5
ci/config.json.ci (3)
- 29-29: The renaming of
numberOfBlockPerCall
toblocksPerCall
is clear and aligns with the goal of standardizing terminology.- 34-34: The addition of the
key
with the valuecrawlTransaction
under thecrawlTransaction
section enhances configuration clarity.- 36-36: The introduction of the
chunkSize
parameter set to 1000 undercrawlTransaction
is a positive change for processing efficiency.src/services/crawl-block/crawl_block.service.ts (1)
- 97-97: The update to calculate
endBlock
usingconfig.crawlBlock.blocksPerCall
aligns with the configuration changes and ensures consistency.src/services/crawl-tx/crawl_tx.service.ts (1)
- 57-57: The update from
config.handleTransaction.key
toconfig.crawlTransaction.key
aligns with the configuration changes and enhances clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
config.json
is excluded by:!**/*.json
Files selected for processing (3)
- ci/config.json.ci (1 hunks)
- src/services/crawl-block/crawl_block.service.ts (1 hunks)
- src/services/crawl-tx/crawl_tx.service.ts (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- ci/config.json.ci
- src/services/crawl-block/crawl_block.service.ts
- src/services/crawl-tx/crawl_tx.service.ts
6c9c79f
to
8c12929
Compare
Summary by CodeRabbit